mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix patch linter (#21495)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-12-13 09:18:45 -08:00 • committed by GitHub
parent 7932e28aa2
commit a90b5f8421
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
28 changed files with 85 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

4
script/lint.js
View file

@ -184,7 +184,7 @@ const LINTERS = [ {
let ok = true
filenames.filter(f => f.endsWith('.patch')).forEach(f => {
const patchText = fs.readFileSync(f, 'utf8')
if (/^Subject: .*$\s+^diff/.test(patchText)) {
if (/^Subject: .*$\s+^diff/m.test(patchText)) {
console.warn(`Patch file '${f}' has no description. Every patch must contain a justification for why the patch exists and the plan for its removal.`)
ok = false
}
@ -246,7 +246,7 @@ async function findFiles (args, linter) {
return []
}
} else if (args.only) {
whitelist = new Set(args._)
whitelist = new Set(args._.map(p => path.resolve(p)))
}
// accumulate the raw list of files