mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore: remove only on deprecations api spec (#14564)

Browse source 
* chore: remove only

* add option to ignore missing properties
This commit is contained in:
Shelley Vohr 2018-09-11 23:00:41 -07:00 committed by GitHub
parent ebbaa4f89b
commit a8a610cb34
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/browser/api/app.js
View file

@ -44,7 +44,7 @@ const nativeFn = app.getAppMetrics
app.getAppMetrics = () => { app.getAppMetrics = () => {
let metrics = nativeFn.call(app) let metrics = nativeFn.call(app)
for (const metric of metrics) { for (const metric of metrics) {
deprecate.removeProperty(metric, 'memory') deprecate.removeProperty(metric, 'memory', true)
} }
return metrics return metrics

3
lib/common/api/deprecate.js
View file

@ -63,7 +63,7 @@ const deprecate = {
this.emit(oldName, ...args) this.emit(oldName, ...args)
}) })
}, },
removeProperty: (object, deprecated) => { removeProperty: (object, deprecated, ignoreMissingProps = false) => {
let warned = false let warned = false
let warn = () => { let warn = () => {
if (!(warned || process.noDeprecation)) { if (!(warned || process.noDeprecation)) {
@ -73,6 +73,7 @@ const deprecate = {
} }
if (!(deprecated in object)) { if (!(deprecated in object)) {
if (ignoreMissingProps) return
throw new Error('Cannot deprecate a property on an object which does not have that property') throw new Error('Cannot deprecate a property on an object which does not have that property')
} }

2
spec/api-deprecations-spec.js
View file

@ -5,7 +5,7 @@ const {deprecations, deprecate, nativeImage} = require('electron')
const {expect} = chai const {expect} = chai
chai.use(dirtyChai) chai.use(dirtyChai)
describe.only('deprecations', () => { describe('deprecations', () => {
beforeEach(() => { beforeEach(() => {
deprecations.setHandler(null) deprecations.setHandler(null)
process.throwDeprecation = true process.throwDeprecation = true