mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: remove libcc from release not generator (#22271)

Browse source
This commit is contained in:
Shelley Vohr 2020-02-20 05:39:25 +00:00 • committed by GitHub
parent cdc13919b2
commit a87e0f495d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

53
script/release/notes/notes.js
View file

@ -18,7 +18,7 @@ const CHECK_INTERVAL = 5000
const CACHE_DIR = path.resolve(__dirname, '.cache') const CACHE_DIR = path.resolve(__dirname, '.cache')
const NO_NOTES = 'No notes' const NO_NOTES = 'No notes'
const FOLLOW_REPOS = [ 'electron/electron', 'electron/libchromiumcontent', 'electron/node' ] const FOLLOW_REPOS = [ 'electron/electron', 'electron/node' ]
const breakTypes = new Set(['breaking-change']) const breakTypes = new Set(['breaking-change'])
const docTypes = new Set(['doc', 'docs']) const docTypes = new Set(['doc', 'docs'])
@ -341,44 +341,6 @@ const addRepoToPool = async (pool, repo, from, to) => {
**** Other Repos **** Other Repos
***/ ***/
// other repos - gyp
const getGypSubmoduleRef = async (dir, point) => {
// example: '160000 commit 028b0af83076cec898f4ebce208b7fadb715656e libchromiumcontent'
const response = await runGit(
path.dirname(dir),
['ls-tree', '-t', point, path.basename(dir)]
)
const line = response.split('\n').filter(line => line.startsWith('160000')).shift()
const tokens = line ? line.split(/\s/).map(token => token.trim()) : null
const ref = tokens && tokens.length >= 3 ? tokens[2] : null
return ref
}
const getDependencyCommitsGyp = async (pool, fromRef, toRef) => {
const commits = []
const repos = [{
owner: 'electron',
repo: 'libchromiumcontent',
dir: path.resolve(ELECTRON_VERSION, 'vendor', 'libchromiumcontent')
}, {
owner: 'electron',
repo: 'node',
dir: path.resolve(ELECTRON_VERSION, 'vendor', 'node')
}]
for (const repo of repos) {
const from = await getGypSubmoduleRef(repo.dir, fromRef)
const to = await getGypSubmoduleRef(repo.dir, toRef)
await addRepoToPool(pool, repo, from, to)
}
return commits
}
// other repos - gn // other repos - gn
const getDepsVariable = async (ref, key) => { const getDepsVariable = async (ref, key) => {
@ -416,17 +378,6 @@ const getDependencyCommitsGN = async (pool, fromRef, toRef) => {
} }
} }
// other repos - controller
const getDependencyCommits = async (pool, from, to) => {
const filename = path.resolve(ELECTRON_VERSION, 'vendor', 'libchromiumcontent')
const useGyp = fs.existsSync(filename)
return useGyp
? getDependencyCommitsGyp(pool, from, to)
: getDependencyCommitsGN(pool, from, to)
}
// Changes are interesting if they make a change relative to a previous // Changes are interesting if they make a change relative to a previous
// release in the same series. For example if you fix a Y.0.0 bug, that // release in the same series. For example if you fix a Y.0.0 bug, that
// should be included in the Y.0.1 notes even if it's also tropped back // should be included in the Y.0.1 notes even if it's also tropped back
@ -474,7 +425,7 @@ const getNotes = async (fromRef, toRef, newVersion) => {
semver.major(fromRef) === semver.major(toRef) semver.major(fromRef) === semver.major(toRef)
if (includeDeps) { if (includeDeps) {
await getDependencyCommits(pool, fromRef, toRef) await getDependencyCommitsGN(pool, fromRef, toRef)
} }
// remove any old commits // remove any old commits