mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use = default to define trivial destructors (#46165)

Browse source 
refactor: use '= default' to define trivial destructors
This commit is contained in:
Charles Kerr 2025-03-21 16:15:34 -05:00 • committed by GitHub
parent db47267be4
commit a81e11d9de
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_view.cc
View file

@ -155,7 +155,7 @@ class JSLayoutManager : public views::LayoutManagerBase {
public: public:
explicit JSLayoutManager(LayoutCallback layout_callback) explicit JSLayoutManager(LayoutCallback layout_callback)
: layout_callback_(std::move(layout_callback)) {} : layout_callback_(std::move(layout_callback)) {}
~JSLayoutManager() override {} ~JSLayoutManager() override = default;
// views::LayoutManagerBase // views::LayoutManagerBase
views::ProposedLayout CalculateProposedLayout( views::ProposedLayout CalculateProposedLayout(

6
shell/browser/extensions/api/extension_action/extension_action_api.cc
View file

@ -29,8 +29,6 @@ void ExtensionActionAPI::Observer::OnExtensionActionUpdated(
void ExtensionActionAPI::Observer::OnExtensionActionAPIShuttingDown() {} void ExtensionActionAPI::Observer::OnExtensionActionAPIShuttingDown() {}
ExtensionActionAPI::Observer::~Observer() {}
// //
// ExtensionActionAPI // ExtensionActionAPI
// //
@ -38,8 +36,6 @@ ExtensionActionAPI::Observer::~Observer() {}
ExtensionActionAPI::ExtensionActionAPI(content::BrowserContext* context) ExtensionActionAPI::ExtensionActionAPI(content::BrowserContext* context)
: browser_context_(context), extension_prefs_(nullptr) {} : browser_context_(context), extension_prefs_(nullptr) {}
ExtensionActionAPI::~ExtensionActionAPI() {}
// static // static
BrowserContextKeyedAPIFactory<ExtensionActionAPI>* BrowserContextKeyedAPIFactory<ExtensionActionAPI>*
ExtensionActionAPI::GetFactoryInstance() { ExtensionActionAPI::GetFactoryInstance() {
@ -65,8 +61,6 @@ void ExtensionActionAPI::Shutdown() {}
ExtensionActionFunction::ExtensionActionFunction() {} ExtensionActionFunction::ExtensionActionFunction() {}
ExtensionActionFunction::~ExtensionActionFunction() {}
ExtensionFunction::ResponseAction ExtensionActionFunction::Run() { ExtensionFunction::ResponseAction ExtensionActionFunction::Run() {
return RunExtensionAction(); return RunExtensionAction();
} }

6
shell/browser/extensions/api/extension_action/extension_action_api.h
View file

@ -33,7 +33,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
virtual void OnExtensionActionAPIShuttingDown(); virtual void OnExtensionActionAPIShuttingDown();
protected: protected:
virtual ~Observer(); virtual ~Observer() = default;
}; };
explicit ExtensionActionAPI(content::BrowserContext* context); explicit ExtensionActionAPI(content::BrowserContext* context);
@ -41,7 +41,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
ExtensionActionAPI(const ExtensionActionAPI&) = delete; ExtensionActionAPI(const ExtensionActionAPI&) = delete;
ExtensionActionAPI& operator=(const ExtensionActionAPI&) = delete; ExtensionActionAPI& operator=(const ExtensionActionAPI&) = delete;
~ExtensionActionAPI() override; ~ExtensionActionAPI() override = default;
// Convenience method to get the instance for a profile. // Convenience method to get the instance for a profile.
static ExtensionActionAPI* Get(content::BrowserContext* context); static ExtensionActionAPI* Get(content::BrowserContext* context);
@ -86,7 +86,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
class ExtensionActionFunction : public ExtensionFunction { class ExtensionActionFunction : public ExtensionFunction {
protected: protected:
ExtensionActionFunction(); ExtensionActionFunction();
~ExtensionActionFunction() override; ~ExtensionActionFunction() override = default;
// ExtensionFunction // ExtensionFunction
ResponseAction Run() override; ResponseAction Run() override;

2
shell/browser/net/web_request_api_interface.h
View file

@ -20,7 +20,7 @@ namespace electron {
// Defines the interface for WebRequest API, implemented by api::WebRequestNS. // Defines the interface for WebRequest API, implemented by api::WebRequestNS.
class WebRequestAPI { class WebRequestAPI {
public: public:
virtual ~WebRequestAPI() {} virtual ~WebRequestAPI() = default;
using BeforeSendHeadersCallback = using BeforeSendHeadersCallback =
base::OnceCallback<void(const std::set<std::string>& removed_headers, base::OnceCallback<void(const std::set<std::string>& removed_headers,