diff --git a/patches/common/v8/.patches b/patches/common/v8/.patches index 3a112aea524d..8841e9b399d7 100644 --- a/patches/common/v8/.patches +++ b/patches/common/v8/.patches @@ -12,4 +12,3 @@ build-torque-with-x64-toolchain-on-arm.patch do_not_run_arm_arm64_mksnapshot_binaries.patch deps_revert_9136dd8088a9_from_upstream_v8.patch deps_provide_more_v8_backwards_compatibility.patch -deps_backport_958b761_from_upstream_v8.patch diff --git a/patches/common/v8/deps_backport_958b761_from_upstream_v8.patch b/patches/common/v8/deps_backport_958b761_from_upstream_v8.patch deleted file mode 100644 index 3466755dd26d..000000000000 --- a/patches/common/v8/deps_backport_958b761_from_upstream_v8.patch +++ /dev/null @@ -1,65 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Matheus Marchini -Date: Mon, 17 Sep 2018 16:22:59 -0300 -Subject: deps: backport 958b761 from upstream V8 - -Original commit message: - - [postmortem] add postmortem metadata for symbols - - As discussed in https://github.com/nodejs/llnode/issues/156, we need - postmortem metadata for Symbols to properly print Symbol property - names in postmortem debugging tools. Patch suggested by Ben - Noordhuis - (https://github.com/nodejs/llnode/issues/156#issuecomment-350467852). - - R=bmeurer@google.com, yangguo@google.com - - Change-Id: Ied6d3c079e8b23a9c796bc632c37785ed7dbc118 - Reviewed-on: https://chromium-review.googlesource.com/1205052 - Reviewed-by: Benedikt Meurer - Reviewed-by: Yang Guo - Commit-Queue: Yang Guo - Cr-Commit-Position: refs/heads/master@{#55632} - -Refs: https://github.com/v8/v8/commit/958b761d3392495c3bf635e97fb9bd0e45 - -PR-URL: https://github.com/nodejs/node/pull/22914 -Reviewed-By: Joyee Cheung -Reviewed-By: Colin Ihrig -Reviewed-By: James M Snell - -diff --git a/BUILD.gn b/BUILD.gn -index 78e672e18eff27a3777bd0c0adc94e88a6eb126a..ab185573cdfb788b4e6bb0e2f582d7f36d17fadc 100644 ---- a/BUILD.gn -+++ b/BUILD.gn -@@ -865,6 +865,8 @@ action("postmortem-metadata") { - "src/objects/js-regexp-string-iterator.h", - "src/objects/map.h", - "src/objects/map-inl.h", -+ "src/objects/name.h", -+ "src/objects/name-inl.h", - "src/objects/scope-info.h", - "src/objects/script.h", - "src/objects/script-inl.h", -diff --git a/tools/gen-postmortem-metadata.py b/tools/gen-postmortem-metadata.py -index 8191c8152f5942858cc3a305bdee72d74c4e55e9..9bc1dd66d599f4c5ad8b2c775b145ee0f9cde8f0 100644 ---- a/tools/gen-postmortem-metadata.py -+++ b/tools/gen-postmortem-metadata.py -@@ -417,15 +417,10 @@ def load_objects_from_file(objfilename, checktypes): - # way around. - # - for type in types: -- # -- # Symbols and Strings are implemented using the same classes. -- # -- usetype = re.sub('SYMBOL_', 'STRING_', type); -- - # - # REGEXP behaves like REG_EXP, as in JS_REGEXP_TYPE => JSRegExp. - # -- usetype = re.sub('_REGEXP_', '_REG_EXP_', usetype); -+ usetype = re.sub('_REGEXP_', '_REG_EXP_', type); - - # - # Remove the "_TYPE" suffix and then convert to camel case,