mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: use literals instead of new RegExp() where possible (#38458)

Browse source
This commit is contained in:
Milan Burda 2023-05-30 10:53:11 +02:00 committed by GitHub
parent 0203bd3305
commit a6f7c7690d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
script/prepare-appveyor.js
View file

@ -182,8 +182,7 @@ async function prepareAppVeyorImage (opts) {
if (ROLLER_BRANCH_PATTERN.test(branch)) { if (ROLLER_BRANCH_PATTERN.test(branch)) {
useAppVeyorImage(branch, { ...opts, version: DEFAULT_BUILD_IMAGE, cloudId: DEFAULT_BUILD_CLOUD_ID }); useAppVeyorImage(branch, { ...opts, version: DEFAULT_BUILD_IMAGE, cloudId: DEFAULT_BUILD_CLOUD_ID });
} else { } else {
// eslint-disable-next-line no-control-regex const versionRegex = /chromium_version':\n +'(.+?)',/m;
const versionRegex = new RegExp('chromium_version\':\n +\'(.+?)\',', 'm');
const deps = fs.readFileSync(path.resolve(__dirname, '..', 'DEPS'), 'utf8'); const deps = fs.readFileSync(path.resolve(__dirname, '..', 'DEPS'), 'utf8');
const [, CHROMIUM_VERSION] = versionRegex.exec(deps); const [, CHROMIUM_VERSION] = versionRegex.exec(deps);

3
script/release/prepare-release.js
View file

@ -187,8 +187,7 @@ async function promptForVersion (version) {
// function to determine if there have been commits to main since the last release // function to determine if there have been commits to main since the last release
async function changesToRelease () { async function changesToRelease () {
// eslint-disable-next-line no-useless-escape const lastCommitWasRelease = /^Bump v[0-9]+.[0-9]+.[0-9]+(-beta.[0-9]+)?(-alpha.[0-9]+)?(-nightly.[0-9]+)?$/g;
const lastCommitWasRelease = new RegExp('^Bump v[0-9]+\.[0-9]+\.[0-9]+(-beta\.[0-9]+)?(-alpha\.[0-9]+)?(-nightly\.[0-9]+)?$', 'g');
const lastCommit = await GitProcess.exec(['log', '-n', '1', '--pretty=format:\'%s\''], ELECTRON_DIR); const lastCommit = await GitProcess.exec(['log', '-n', '1', '--pretty=format:\'%s\''], ELECTRON_DIR);
return !lastCommitWasRelease.test(lastCommit.stdout); return !lastCommitWasRelease.test(lastCommit.stdout);
} }