mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Follow object naming conventions for params in the 'context-menu' event

Browse source
This commit is contained in:
Daniel Pham 2016-05-04 10:41:10 -04:00
parent 81eb3e3428
commit a6f2d401fa
3 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
atom/common/native_mate_converters/blink_converter.cc
View file

@ -324,7 +324,7 @@ v8::Local<v8::Value> Converter<blink::WebContextMenuData::InputFieldType>::ToV8(
const blink::WebContextMenuData::InputFieldType& in) { const blink::WebContextMenuData::InputFieldType& in) {
switch (in) { switch (in) {
case blink::WebContextMenuData::InputFieldTypePlainText: case blink::WebContextMenuData::InputFieldTypePlainText:
return mate::StringToV8(isolate, "plain-text"); return mate::StringToV8(isolate, "plainText");
case blink::WebContextMenuData::InputFieldTypePassword: case blink::WebContextMenuData::InputFieldTypePassword:
return mate::StringToV8(isolate, "password"); return mate::StringToV8(isolate, "password");
case blink::WebContextMenuData::InputFieldTypeOther: case blink::WebContextMenuData::InputFieldTypeOther:

2
atom/common/native_mate_converters/ui_base_types_converter.h
View file

@ -22,7 +22,7 @@ struct Converter<ui::MenuSourceType> {
case ui::MENU_SOURCE_TOUCH: case ui::MENU_SOURCE_TOUCH:
return mate::StringToV8(isolate, "touch"); return mate::StringToV8(isolate, "touch");
case ui::MENU_SOURCE_TOUCH_EDIT_MENU: case ui::MENU_SOURCE_TOUCH_EDIT_MENU:
return mate::StringToV8(isolate, "touch-menu"); return mate::StringToV8(isolate, "touchMenu");
default: default:
return mate::StringToV8(isolate, "none"); return mate::StringToV8(isolate, "none");
} }

4
docs/api/web-contents.md
View file

@ -358,10 +358,10 @@ was invoked on.
* `frameCharset` String - The character encoding of the frame on which the * `frameCharset` String - The character encoding of the frame on which the
menu was invoked. menu was invoked.
* `inputFieldType` String - If the context menu was invoked on an input * `inputFieldType` String - If the context menu was invoked on an input
field, the type of that field. Possible values are `none`, `plain-text`, field, the type of that field. Possible values are `none`, `plainText`,
`password`, `other`. `password`, `other`.
* `menuSourceType` String - Input source that invoked the context menu. * `menuSourceType` String - Input source that invoked the context menu.
Can be `none`, `mouse`, `keyboard`, `touch`, `touch-menu`. Can be `none`, `mouse`, `keyboard`, `touch`, `touchMenu`.
Emitted when there is a new context menu that needs to be handled. Emitted when there is a new context menu that needs to be handled.