From a66429dcd8bbafa262519204b9fc1717f72aa21f Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 22 Jul 2024 18:01:33 +0200 Subject: [PATCH] chore: remove unused WrappableBase::AfterInit() (#42987) last caller removed in 6159066c (#22916) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/common/gin_helper/wrappable.cc | 2 -- shell/common/gin_helper/wrappable_base.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/shell/common/gin_helper/wrappable.cc b/shell/common/gin_helper/wrappable.cc index b9fd6e775e0..82ed322b452 100644 --- a/shell/common/gin_helper/wrappable.cc +++ b/shell/common/gin_helper/wrappable.cc @@ -56,8 +56,6 @@ void WrappableBase::InitWith(v8::Isolate* isolate, v8::Local init; if (Dictionary(isolate, wrapper).Get("_init", &init)) init->Call(isolate->GetCurrentContext(), wrapper, 0, nullptr).IsEmpty(); - - AfterInit(isolate); } // static diff --git a/shell/common/gin_helper/wrappable_base.h b/shell/common/gin_helper/wrappable_base.h index 996cb404720..f65e9079b03 100644 --- a/shell/common/gin_helper/wrappable_base.h +++ b/shell/common/gin_helper/wrappable_base.h @@ -45,9 +45,6 @@ class WrappableBase { v8::Isolate* isolate() const { return isolate_; } protected: - // Called after the "_init" method gets called in JavaScript. - virtual void AfterInit(v8::Isolate* isolate) {} - // Bind the C++ class to the JS wrapper. // This method should only be called by classes using Constructor. virtual void InitWith(v8::Isolate* isolate, v8::Local wrapper);