mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Simplify V8 operations.

Browse source
This commit is contained in:
Cheng Zhao 2013-12-05 10:35:57 +08:00
parent 5670ee7693
commit a614134144
1 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
browser/api/atom_api_app.cc
View file

@ -101,11 +101,7 @@ v8::Handle<v8::Value> App::Focus(const v8::Arguments &args) {
// static // static
v8::Handle<v8::Value> App::GetVersion(const v8::Arguments &args) { v8::Handle<v8::Value> App::GetVersion(const v8::Arguments &args) {
v8::HandleScope scope; return ToV8Value(Browser::Get()->GetVersion());
std::string version(Browser::Get()->GetVersion());
return v8::String::New(version.data(), version.size());
} }
// static // static
@ -123,11 +119,7 @@ v8::Handle<v8::Value> App::SetVersion(const v8::Arguments &args) {
// static // static
v8::Handle<v8::Value> App::GetName(const v8::Arguments &args) { v8::Handle<v8::Value> App::GetName(const v8::Arguments &args) {
v8::HandleScope scope; return ToV8Value(Browser::Get()->GetName());
std::string name(Browser::Get()->GetName());
return v8::String::New(name.data(), version.size());
} }
// static // static
@ -179,7 +171,10 @@ v8::Handle<v8::Value> App::AppendArgument(const v8::Arguments &args) {
// static // static
v8::Handle<v8::Value> App::DockBounce(const v8::Arguments& args) { v8::Handle<v8::Value> App::DockBounce(const v8::Arguments& args) {
std::string type = FromV8Value(args[0]); std::string type;
if (!FromV8Arguments(args, &type))
return node::ThrowError("Bad argument");
int request_id = -1; int request_id = -1;
if (type == "critical") if (type == "critical")
@ -189,7 +184,7 @@ v8::Handle<v8::Value> App::DockBounce(const v8::Arguments& args) {
else else
return node::ThrowTypeError("Invalid bounce type"); return node::ThrowTypeError("Invalid bounce type");
return v8::Integer::New(request_id); return ToV8Value(request_id);
} }
// static // static