mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: add missing index arg in navigationHistory.canGoToOffset (#44989)

Browse source 
fix: add missing arg
This commit is contained in:
Alice Zhao 2024-12-12 07:56:27 -08:00 committed by GitHub
parent 6961e9458a
commit a5b4339884
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/browser/api/web-contents.ts
View file

@ -514,9 +514,9 @@ WebContents.prototype.canGoForward = function () {
}; };
const canGoToOffsetDeprecated = deprecate.warnOnce('webContents.canGoToOffset', 'webContents.navigationHistory.canGoToOffset'); const canGoToOffsetDeprecated = deprecate.warnOnce('webContents.canGoToOffset', 'webContents.navigationHistory.canGoToOffset');
WebContents.prototype.canGoToOffset = function () { WebContents.prototype.canGoToOffset = function (index: number) {
canGoToOffsetDeprecated(); canGoToOffsetDeprecated();
return this._canGoToOffset(); return this._canGoToOffset(index);
}; };
const clearHistoryDeprecated = deprecate.warnOnce('webContents.clearHistory', 'webContents.navigationHistory.clear'); const clearHistoryDeprecated = deprecate.warnOnce('webContents.clearHistory', 'webContents.navigationHistory.clear');

2
typings/internal-electron.d.ts vendored
View file

@ -93,7 +93,7 @@ declare namespace Electron {
_historyLength(): number; _historyLength(): number;
_canGoBack(): boolean; _canGoBack(): boolean;
_canGoForward(): boolean; _canGoForward(): boolean;
_canGoToOffset(): boolean; _canGoToOffset(index: number): boolean;
_goBack(): void; _goBack(): void;
_goForward(): void; _goForward(): void;
_goToOffset(index: number): void; _goToOffset(index: number): void;