From a5a068b2eedd161be98e4e75c8ff6789c9a01833 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Wed, 24 Jan 2018 20:50:00 -0600 Subject: [PATCH] fix cpplint errors atom/browser/atom_javascript_dialog_manager.cc:39: Lines should be <= 80 characters long [whitespace/line_length] [2] atom/browser/atom_javascript_dialog_manager.cc:39: If/else bodies with multiple statements require braces [readability/braces] [4] atom/browser/atom_javascript_dialog_manager.cc:62: Lines should be <= 80 characters long [whitespace/line_length] [2] atom/browser/atom_javascript_dialog_manager.cc:89: If/else bodies with multiple statements require braces [readability/braces] [4] --- atom/browser/atom_javascript_dialog_manager.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/atom/browser/atom_javascript_dialog_manager.cc b/atom/browser/atom_javascript_dialog_manager.cc index c209e700015..f29a3d9926f 100644 --- a/atom/browser/atom_javascript_dialog_manager.cc +++ b/atom/browser/atom_javascript_dialog_manager.cc @@ -36,7 +36,9 @@ void AtomJavaScriptDialogManager::RunJavaScriptDialog( origin_counts_[origin] = 0; } - if (origin_counts_[origin] == -1) return callback.Run(false, base::string16());; + if (origin_counts_[origin] == -1) { + return callback.Run(false, base::string16()); + } if (dialog_type != JavaScriptDialogType::JAVASCRIPT_DIALOG_TYPE_ALERT && dialog_type != JavaScriptDialogType::JAVASCRIPT_DIALOG_TYPE_CONFIRM) { @@ -62,8 +64,8 @@ void AtomJavaScriptDialogManager::RunJavaScriptDialog( atom::ShowMessageBox(NativeWindow::FromWebContents(web_contents), atom::MessageBoxType::MESSAGE_BOX_TYPE_NONE, buttons, -1, 0, atom::MessageBoxOptions::MESSAGE_BOX_NONE, "", - base::UTF16ToUTF8(message_text), "", checkbox_string, false, - gfx::ImageSkia(), + base::UTF16ToUTF8(message_text), "", checkbox_string, + false, gfx::ImageSkia(), base::Bind(&OnMessageBoxCallback, callback, origin, &origin_counts_)); }