mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use std::size(args) instead of hardcoded values (#34651)

Browse source
This commit is contained in:
Milan Burda 2022-06-22 10:15:27 +02:00 • committed by GitHub
parent bf52318c76
commit a5869fe997
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/common/api/electron_api_v8_util.cc
View file

@ -2,6 +2,7 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include <iterator>
#include <utility>
#include "base/hash/hash.h"
@ -106,9 +107,11 @@ void RequestGarbageCollectionForTesting(v8::Isolate* isolate) {
// This causes a fatal error by creating a circular extension dependency.
void TriggerFatalErrorForTesting(v8::Isolate* isolate) {
static const char* aDeps[] = {"B"};
v8::RegisterExtension(std::make_unique<v8::Extension>("A", "", 1, aDeps));
v8::RegisterExtension(
std::make_unique<v8::Extension>("A", "", std::size(aDeps), aDeps));
static const char* bDeps[] = {"A"};
v8::RegisterExtension(std::make_unique<v8::Extension>("B", "", 1, bDeps));
v8::RegisterExtension(
std::make_unique<v8::Extension>("B", "", std::size(aDeps), bDeps));
v8::ExtensionConfiguration config(1, bDeps);
v8::Context::New(isolate, &config);
}