From a54dd1085a128f51de6123dc9bc9d80cc0d2b0b1 Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Sun, 11 Nov 2018 22:52:27 -0500 Subject: [PATCH] feat: expose showAboutPanel for MacOS (#15674) --- atom/browser/api/atom_api_app.cc | 2 ++ docs/api/app.md | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/atom/browser/api/atom_api_app.cc b/atom/browser/api/atom_api_app.cc index 3f0e3e02b51e..0c577d55345c 100644 --- a/atom/browser/api/atom_api_app.cc +++ b/atom/browser/api/atom_api_app.cc @@ -1292,6 +1292,8 @@ void App::BuildPrototype(v8::Isolate* isolate, base::Bind(&Browser::UpdateCurrentActivity, browser)) .SetMethod("setAboutPanelOptions", base::Bind(&Browser::SetAboutPanelOptions, browser)) + .SetMethod("showAboutPanel", + base::Bind(&Browser::ShowAboutPanel, browser)) #endif #if defined(OS_WIN) .SetMethod("setUserTasks", base::Bind(&Browser::SetUserTasks, browser)) diff --git a/docs/api/app.md b/docs/api/app.md index 5f3241e060a5..7b685ef1cd5f 100644 --- a/docs/api/app.md +++ b/docs/api/app.md @@ -1064,6 +1064,11 @@ details. Disabled by default. **Note:** Rendering accessibility tree can significantly affect the performance of your app. It should not be enabled by default. +### `app.showAboutPanel()` _macOS_ + +Show the about panel with the values defined in the app's +`.plist` file or with the options set via `app.setAboutPanelOptions(options)`. + ### `app.setAboutPanelOptions(options)` _macOS_ * `options` Object