mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #14045 from electron/enable-mixed-sandbox

Browse source 
fix: re-enable mixed-sandbox tests
This commit is contained in:
John Kleinschmidt 2018-08-13 08:48:19 -07:00 committed by GitHub
commit a53a5ac071
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/api-app-spec.js
View file

@ -869,13 +869,6 @@ describe('app module', () => {
})
describe('when app.enableMixedSandbox() is called', () => {
// TODO(zcbenz): Find out why it fails in CI.
before(function () {
if (isCI && process.platform === 'win32') {
this.skip()
}
})
it('adds --enable-sandbox to render processes created with sandbox: true', done => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app')
appProcess = ChildProcess.spawn(remote.process.execPath, [appPath])
@ -898,13 +891,6 @@ describe('app module', () => {
})
describe('when the app is launched with --enable-mixed-sandbox', () => {
// TODO(zcbenz): Find out why it fails in CI.
before(function () {
if (isCI && process.platform === 'win32') {
this.skip()
}
})
it('adds --enable-sandbox to render processes created with sandbox: true', done => {
const appPath = path.join(__dirname, 'fixtures', 'api', 'mixed-sandbox-app')
appProcess = ChildProcess.spawn(remote.process.execPath, [appPath, '--enable-mixed-sandbox'])