mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: crash on invalid zoomFactor (#22673)

Browse source
This commit is contained in:
Shelley Vohr 2020-03-13 23:13:05 +00:00 • committed by GitHub
parent 9c5874306d
commit a4c4c86b9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 37 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
shell/renderer/api/electron_api_web_frame.cc
View file

@ -2,6 +2,7 @@
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include <limits>
#include <memory>
#include <string>
#include <utility>
@ -275,7 +276,14 @@ double GetZoomLevel(v8::Local<v8::Value> window) {
return result;
}
void SetZoomFactor(v8::Local<v8::Value> window, double factor) {
void SetZoomFactor(gin_helper::ErrorThrower thrower,
v8::Local<v8::Value> window,
double factor) {
if (factor < std::numeric_limits<double>::epsilon()) {
thrower.ThrowError("'zoomFactor' must be a double greater than 0.0");
return;
}
SetZoomLevel(window, blink::PageZoomFactorToZoomLevel(factor));
}