mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Change qualifier of ShowSaveDialog() parameter

Browse source 
The normal convention in the codebase is to not use references
or 'const' for primitives like 'bool' and 'int'.
This commit is contained in:
Tan Wang Leng 2017-02-09 21:33:33 +08:00
parent 72723646dd
commit a4a71a1dc9
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_dialog.cc
View file

@ -95,7 +95,7 @@ void ShowSaveDialog(const std::string& title,
const file_dialog::Filters& filters, const file_dialog::Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
atom::NativeWindow* window, atom::NativeWindow* window,
mate::Arguments* args) { mate::Arguments* args) {
v8::Local<v8::Value> peek = args->PeekNext(); v8::Local<v8::Value> peek = args->PeekNext();

4
atom/browser/ui/file_dialog.h
View file

@ -62,7 +62,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
base::FilePath* path); base::FilePath* path);
void ShowSaveDialog(atom::NativeWindow* parent_window, void ShowSaveDialog(atom::NativeWindow* parent_window,
@ -72,7 +72,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
const SaveDialogCallback& callback); const SaveDialogCallback& callback);
} // namespace file_dialog } // namespace file_dialog

4
atom/browser/ui/file_dialog_gtk.cc
View file

@ -279,7 +279,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
base::FilePath* path) { base::FilePath* path) {
FileChooserDialog save_dialog(GTK_FILE_CHOOSER_ACTION_SAVE, parent_window, FileChooserDialog save_dialog(GTK_FILE_CHOOSER_ACTION_SAVE, parent_window,
title, button_label, default_path, filters); title, button_label, default_path, filters);
@ -300,7 +300,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
const SaveDialogCallback& callback) { const SaveDialogCallback& callback) {
FileChooserDialog* save_dialog = new FileChooserDialog( FileChooserDialog* save_dialog = new FileChooserDialog(
GTK_FILE_CHOOSER_ACTION_SAVE, parent_window, title, button_label, GTK_FILE_CHOOSER_ACTION_SAVE, parent_window, title, button_label,

4
atom/browser/ui/file_dialog_mac.mm
View file

@ -191,7 +191,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
base::FilePath* path) { base::FilePath* path) {
DCHECK(path); DCHECK(path);
NSSavePanel* dialog = [NSSavePanel savePanel]; NSSavePanel* dialog = [NSSavePanel savePanel];
@ -214,7 +214,7 @@ void ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
const SaveDialogCallback& c) { const SaveDialogCallback& c) {
NSSavePanel* dialog = [NSSavePanel savePanel]; NSSavePanel* dialog = [NSSavePanel savePanel];

4
atom/browser/ui/file_dialog_win.cc
View file

@ -272,7 +272,7 @@ bool ShowSaveDialog(atom::NativeWindow* parent_window,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
base::FilePath* path) { base::FilePath* path) {
FileDialog<CShellFileSaveDialog> save_dialog( FileDialog<CShellFileSaveDialog> save_dialog(
default_path, title, button_label, filters, default_path, title, button_label, filters,
@ -296,7 +296,7 @@ void ShowSaveDialog(atom::NativeWindow* parent,
const Filters& filters, const Filters& filters,
const std::string& message, const std::string& message,
const std::string& name_field_label, const std::string& name_field_label,
const bool& shows_tag_field, bool shows_tag_field,
const SaveDialogCallback& callback) { const SaveDialogCallback& callback) {
RunState run_state; RunState run_state;
if (!CreateDialogThread(&run_state)) { if (!CreateDialogThread(&run_state)) {