mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: add static promise resolution helpers (#17223)

Browse source 
* chore: add static promise resolution helpers

* address feedback

* address feedback from review
This commit is contained in:
Shelley Vohr 2019-03-07 18:07:04 -08:00 • committed by Samuel Attard
parent 61fc95417b
commit a4418a9014
2 changed files with 91 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

76
atom/common/promise_util.h
View file

@ -6,9 +6,12 @@
#define ATOM_COMMON_PROMISE_UTIL_H_
#include <string>
#include <utility>
#include "atom/common/api/locker.h"
#include "atom/common/native_mate_converters/callback.h"
#include "base/task/post_task.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h"
#include "native_mate/converter.h"
@ -39,6 +42,45 @@ class Promise {
return v8::Local<v8::Context>::New(isolate_, context_);
}
// helpers for promise resolution and rejection
template <typename T>
static void ResolvePromise(Promise promise, T result) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(
[](Promise promise, T result) { promise.Resolve(result); },
std::move(promise), std::move(result)));
} else {
promise.Resolve(result);
}
}
static void ResolveEmptyPromise(Promise promise) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce([](Promise promise) { promise.Resolve(); },
std::move(promise)));
} else {
promise.Resolve();
}
}
static void RejectPromise(Promise promise, std::string errmsg) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(
[](Promise promise, std::string errmsg) {
promise.RejectWithErrorMessage(errmsg);
},
std::move(promise), std::move(errmsg)));
} else {
promise.RejectWithErrorMessage(errmsg);
}
}
v8::Local<v8::Promise> GetHandle() const;
v8::Maybe<bool> Resolve() {
@ -125,6 +167,40 @@ class CopyablePromise {
CopyablePromise(const CopyablePromise&);
~CopyablePromise();
template <typename T>
static void ResolveCopyablePromise(const CopyablePromise& promise, T result) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(Promise::ResolvePromise, promise.GetPromise(),
std::move(result)));
} else {
promise.GetPromise().Resolve(result);
}
}
static void ResolveEmptyCopyablePromise(const CopyablePromise& promise) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(Promise::ResolveEmptyPromise, promise.GetPromise()));
} else {
promise.GetPromise().Resolve();
}
}
static void RejectCopyablePromise(const CopyablePromise& promise,
std::string errmsg) {
if (!content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)) {
base::PostTaskWithTraits(
FROM_HERE, {content::BrowserThread::UI},
base::BindOnce(Promise::RejectPromise, promise.GetPromise(),
std::move(errmsg)));
} else {
promise.GetPromise().RejectWithErrorMessage(errmsg);
}
}
Promise GetPromise() const;
private: