mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Unify how we throw exceptions

Browse source
This commit is contained in:
Cheng Zhao 2015-03-26 11:34:41 +08:00
parent 1a6677bdc3
commit a4342fd5ba
2 changed files with 7 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/api/atom_api_window.cc
View file

@ -142,13 +142,11 @@ void Window::OnRendererResponsive() {
// static
mate::Wrappable* Window::New(v8::Isolate* isolate,
const mate::Dictionary& options) {
if (Browser::Get()->is_ready()) {
return new Window(options);
} else {
isolate->ThrowException(v8::Exception::TypeError(mate::StringToV8(
isolate, "Can not create BrowserWindow before app is ready")));
if (!Browser::Get()->is_ready()) {
node::ThrowError("Cannot create BrowserWindow before app is ready");
return nullptr;
}
return new Window(options);
}
void Window::Destroy() {