refactor: ginify Tray (#22822)

* refactor: ginify Tray

* lint

* improve argument parsing logic

* remove redundant imports from tray.js

* new Tray produces an instanceof Tray

* make Constructible generic

* lint

* clean up on exit
This commit is contained in:
Jeremy Apthorp 2020-03-29 18:32:02 -07:00 committed by GitHub
parent 76ae3b7ecb
commit a3e28788ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 380 additions and 88 deletions

View file

@ -0,0 +1,33 @@
// Copyright (c) 2020 Slack Technologies, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#include "shell/common/gin_helper/cleaned_up_at_exit.h"
#include "base/containers/flat_set.h"
#include "base/no_destructor.h"
namespace gin_helper {
base::flat_set<CleanedUpAtExit*>& GetDoomed() {
static base::NoDestructor<base::flat_set<CleanedUpAtExit*>> doomed;
return *doomed;
}
CleanedUpAtExit::CleanedUpAtExit() {
GetDoomed().insert(this);
}
CleanedUpAtExit::~CleanedUpAtExit() {
GetDoomed().erase(this);
}
// static
void CleanedUpAtExit::DoCleanup() {
auto& doomed = GetDoomed();
while (!doomed.empty()) {
auto iter = doomed.begin();
delete *iter;
// It removed itself from the list.
}
}
} // namespace gin_helper