From a3af8ea76856f704f7d4b4239319fd444c96f2bd Mon Sep 17 00:00:00 2001 From: Keeley Hammond Date: Mon, 23 Sep 2024 16:58:46 -0700 Subject: [PATCH] build: use Node 20 in Appveyor images (#43897) * build: update Appveyor to Node 20 * build: update appveyor images * chore: return bake script to original form --- appveyor-woa.yml | 2 +- appveyor.yml | 2 +- script/setup-win-for-dev.bat | 5 ++++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/appveyor-woa.yml b/appveyor-woa.yml index c22f31c7df0b..5154a5d3d0f9 100644 --- a/appveyor-woa.yml +++ b/appveyor-woa.yml @@ -29,7 +29,7 @@ version: 1.0.{build} build_cloud: electronhq-16-core -image: e-130.0.6695.0 +image: e-130.0.6695.0-node-20 environment: GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache ELECTRON_OUT_DIR: Default diff --git a/appveyor.yml b/appveyor.yml index a44b7904c24d..67855a8daff7 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -29,7 +29,7 @@ version: 1.0.{build} build_cloud: electronhq-16-core -image: e-130.0.6695.0 +image: e-130.0.6695.0-node-20 environment: GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache ELECTRON_OUT_DIR: Default diff --git a/script/setup-win-for-dev.bat b/script/setup-win-for-dev.bat index ee71a3ab710d..af870d068beb 100644 --- a/script/setup-win-for-dev.bat +++ b/script/setup-win-for-dev.bat @@ -56,11 +56,14 @@ REM Install Windows SDK choco install windows-sdk-11-version-22h2-all REM Install nodejs python git and yarn needed dependencies -choco install -y --force nodejs --version=18.12.1 +choco install -y --force nodejs --version=20.9.0 choco install -y python2 git yarn choco install python --version 3.7.9 call C:\ProgramData\chocolatey\bin\RefreshEnv.cmd SET PATH=C:\Python27\;C:\Python27\Scripts;C:\Python39\;C:\Python39\Scripts;%PATH% +if not exist "C:\Users\appveyor\AppData\Roaming\npm" ( + mkdir "C:\Users\appveyor\AppData\Roaming\npm" +) REM Setup Depot Tools git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git C:\depot_tools