Fix hanlding trailing slash in asar package, close #2222

atom/common/asar/archive.cc

@@ -54,6 +54,11 @@ bool GetChildNode(const base::DictionaryValue* root,
                   const std::string& name,
                   const base::DictionaryValue* dir,
                   const base::DictionaryValue** out) {
+  if (name == "") {
+    *out = root;
+    return true;
+  }
+
   const base::DictionaryValue* files = NULL;
   return GetFilesNode(root, dir, &files) &&
          files->GetDictionaryWithoutPathExpansion(name, out);

spec/asar-spec.coffee

@@ -85,6 +85,11 @@ describe 'asar package', ->
           done()
 
     describe 'fs.lstatSync', ->
+      it 'handles path with trailing slash correctly', ->
+        p = path.join fixtures, 'asar', 'a.asar', 'link2', 'link2', 'file1'
+        fs.lstatSync p
+        fs.lstatSync p + '/'
+
       it 'returns information of root', ->
         p = path.join fixtures, 'asar', 'a.asar'
         stats = fs.lstatSync p
@@ -136,6 +141,10 @@ describe 'asar package', ->
           assert.throws throws, /ENOENT/
 
     describe 'fs.lstat', ->
+      it 'handles path with trailing slash correctly', (done) ->
+        p = path.join fixtures, 'asar', 'a.asar', 'link2', 'link2', 'file1'
+        fs.lstat p + '/', done
+
       it 'returns information of root', (done) ->
         p = path.join fixtures, 'asar', 'a.asar'
         stats = fs.lstat p, (err, stats) ->