build: improve logging on http errors during release process (#43759)
* build: improve logging on http errors during release process (#43756) * build: improve logging on http errors during release process (again) (#43757) * build: improve logging on http errors during release process (again, but more) (#43758)
This commit is contained in:
parent
888928887c
commit
a27df94f71
3 changed files with 37 additions and 7 deletions
|
@ -22,17 +22,27 @@ async function getAssetContents (repo, assetId) {
|
||||||
const response = await got(url, {
|
const response = await got(url, {
|
||||||
followRedirect: false,
|
followRedirect: false,
|
||||||
method: 'HEAD',
|
method: 'HEAD',
|
||||||
headers
|
headers,
|
||||||
|
throwHttpErrors: false
|
||||||
});
|
});
|
||||||
|
|
||||||
|
if (response.statusCode !== 302 && response.statusCode !== 301) {
|
||||||
|
console.error('Failed to HEAD github asset contents for redirect: ' + url);
|
||||||
|
throw new Error('Unexpected status HEAD\'ing github asset for redirect: ' + response.statusCode);
|
||||||
|
}
|
||||||
|
|
||||||
if (!response.headers.location) {
|
if (!response.headers.location) {
|
||||||
console.error(response.headers, `${response.body}`.slice(0, 300));
|
console.error(response.headers, `${response.body}`.slice(0, 300));
|
||||||
throw new Error(`cannot find asset[${assetId}], asset download did not redirect`);
|
throw new Error(`cannot find asset[${assetId}], asset download did not redirect`);
|
||||||
}
|
}
|
||||||
|
|
||||||
const fileResponse = await got(response.headers.location);
|
const fileResponse = await got(response.headers.location, {
|
||||||
|
throwHttpErrors: false
|
||||||
|
});
|
||||||
|
|
||||||
if (fileResponse.statusCode !== 200) {
|
if (fileResponse.statusCode !== 200) {
|
||||||
console.error(fileResponse.headers, `${fileResponse.body}`.slice(0, 300));
|
console.error(fileResponse.headers, `${fileResponse.body}`.slice(0, 300));
|
||||||
throw new Error(`cannot download asset[${assetId}] from ${response.headers.location}, got status: ${fileResponse.status}`);
|
throw new Error(`cannot download asset[${assetId}] from ${response.headers.location}, got status: ${fileResponse.statusCode}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
return fileResponse.body;
|
return fileResponse.body;
|
||||||
|
|
|
@ -15,8 +15,13 @@ module.exports = async function getUrlHash (targetUrl, algorithm = 'sha256', att
|
||||||
search: search.toString()
|
search: search.toString()
|
||||||
});
|
});
|
||||||
try {
|
try {
|
||||||
const resp = await got(functionUrl);
|
const resp = await got(functionUrl, {
|
||||||
if (resp.statusCode !== 200) throw new Error('non-200 status code received from hasher function');
|
throwHttpErrors: false
|
||||||
|
});
|
||||||
|
if (resp.statusCode !== 200) {
|
||||||
|
console.error('bad hasher function response:', resp.body.trim());
|
||||||
|
throw new Error('non-200 status code received from hasher function');
|
||||||
|
}
|
||||||
if (!resp.body) throw new Error('Successful lambda call but failed to get valid hash');
|
if (!resp.body) throw new Error('Successful lambda call but failed to get valid hash');
|
||||||
|
|
||||||
return resp.body.trim();
|
return resp.body.trim();
|
||||||
|
|
|
@ -397,9 +397,15 @@ async function verifyDraftGitHubReleaseAssets (release) {
|
||||||
const response = await got(url, {
|
const response = await got(url, {
|
||||||
followRedirect: false,
|
followRedirect: false,
|
||||||
method: 'HEAD',
|
method: 'HEAD',
|
||||||
headers
|
headers,
|
||||||
|
throwHttpErrors: false
|
||||||
});
|
});
|
||||||
|
|
||||||
|
if (response.statusCode !== 302 && response.statusCode !== 301) {
|
||||||
|
console.error('Failed to HEAD github asset: ' + url);
|
||||||
|
throw new Error('Unexpected status HEAD\'ing github asset: ' + response.statusCode);
|
||||||
|
}
|
||||||
|
|
||||||
return { url: response.headers.location, file: asset.name };
|
return { url: response.headers.location, file: asset.name };
|
||||||
})).catch(err => {
|
})).catch(err => {
|
||||||
console.error(`${fail} Error downloading files from GitHub`, err);
|
console.error(`${fail} Error downloading files from GitHub`, err);
|
||||||
|
@ -410,7 +416,16 @@ async function verifyDraftGitHubReleaseAssets (release) {
|
||||||
}
|
}
|
||||||
|
|
||||||
async function getShaSumMappingFromUrl (shaSumFileUrl, fileNamePrefix) {
|
async function getShaSumMappingFromUrl (shaSumFileUrl, fileNamePrefix) {
|
||||||
const response = await got(shaSumFileUrl);
|
const response = await got(shaSumFileUrl, {
|
||||||
|
throwHttpErrors: false
|
||||||
|
});
|
||||||
|
|
||||||
|
if (response.statusCode !== 200) {
|
||||||
|
console.error('Failed to fetch SHASUM mapping: ' + shaSumFileUrl);
|
||||||
|
console.error('Bad SHASUM mapping response: ' + response.body.trim());
|
||||||
|
throw new Error('Unexpected status fetching SHASUM mapping: ' + response.statusCode);
|
||||||
|
}
|
||||||
|
|
||||||
const raw = response.body;
|
const raw = response.body;
|
||||||
return raw.split('\n').map(line => line.trim()).filter(Boolean).reduce((map, line) => {
|
return raw.split('\n').map(line => line.trim()).filter(Boolean).reduce((map, line) => {
|
||||||
const [sha, file] = line.replace(' ', ' ').split(' ');
|
const [sha, file] = line.replace(' ', ' ').split(' ');
|
||||||
|
|
Loading…
Reference in a new issue