mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix windows tests

Browse source
This commit is contained in:
Samuel Attard 2018-02-16 16:02:10 +11:00
parent 549042160f
commit a20b379f26
2 changed files with 27 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/browser/api/auto-updater/auto-updater-win.js
View file

@ -19,12 +19,16 @@ class AutoUpdater extends EventEmitter {
setFeedURL (options) {
let updateURL
if (typeof options === 'string') {
updateURL = options
} else if (typeof options === 'object' && typeof options.url === 'string') {
if (typeof options === 'object') {
if (typeof options.url === 'string') {
updateURL = options.url
} else {
throw new Error('Expected options.url to be a string but none was provided')
throw new Error('Expected options object to contain a \'url\' string property in setFeedUrl call')
}
} else if (typeof options === 'string') {
updateURL = options
} else {
throw new Error('Expected an options object with a \'url\' property to be provided')
}
this.updateURL = updateURL
}

38
spec/api-auto-updater-spec.js
View file

@ -29,6 +29,25 @@ describe('autoUpdater module', function () {
})
})
describe('getFeedURL', function () {
it('returns a falsey value by default', function () {
assert.ok(!autoUpdater.getFeedURL())
})
it('correctly fetches the previously set FeedURL', function (done) {
if (process.platform !== 'win32') {
// FIXME(alexeykuzmin): Skip the test.
// this.skip()
return done()
}
const updateURL = 'https://fake-update.electron.io'
autoUpdater.setFeedURL(updateURL)
assert.equal(autoUpdater.getFeedURL(), updateURL)
done()
})
})
describe('setFeedURL', function () {
describe('on Mac or Windows', () => {
const noThrow = (fn) => {
@ -106,25 +125,6 @@ describe('autoUpdater module', function () {
})
})
describe('getFeedURL', function () {
it('returns a falsey value by default', function () {
assert.ok(!autoUpdater.getFeedURL())
})
it('correctly fetches the previously set FeedURL', function (done) {
if (process.platform !== 'win32') {
// FIXME(alexeykuzmin): Skip the test.
// this.skip()
return done()
}
const updateURL = 'https://fake-update.electron.io'
autoUpdater.setFeedURL(updateURL)
assert.equal(autoUpdater.getFeedURL(), updateURL)
done()
})
})
describe('quitAndInstall', function () {
it('emits an error on Windows when no update is available', function (done) {
if (process.platform !== 'win32') {