fix: make windowMenu role correct on MacOS (#15930)

2018-12-03 11:52:46 -08:00 · 2018-12-03 11:52:46 -08:00 · a1a431eb87
commit a1a431eb87
parent 3ddd917ff4
3 changed files with 15 additions and 31 deletions
--- a/lib/browser/api/menu-item-roles.js
+++ b/lib/browser/api/menu-item-roles.js
@ -216,17 +216,23 @@ const roles = {
        role: 'minimize'
      },
      {
-        role: 'close'
+        role: 'zoom'
      },
-
+      process.platform !== 'darwin' ? {
+        label: 'close'
+      } : null,
      process.platform === 'darwin' ? {
        type: 'separator'
      } : null,
-
      process.platform === 'darwin' ? {
        role: 'front'
+      } : null,
+      process.platform === 'darwin' ? {
+        type: 'separator'
+      } : null,
+      process.platform === 'darwin' ? {
+        role: 'window'
      } : null
-
    ]
  }
 }