From a11c975a2da19c326543768196623ddda1fafdb2 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Tue, 2 Jul 2024 13:54:30 +0200 Subject: [PATCH] build: strip linux release binaries (#42743) build: strip linux release binaries (#42675) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond --- .github/actions/build-electron/action.yml | 3 +++ .github/workflows/linux-publish.yml | 3 +++ .github/workflows/pipeline-segment-electron-build.yml | 6 ++++++ 3 files changed, 12 insertions(+) diff --git a/.github/actions/build-electron/action.yml b/.github/actions/build-electron/action.yml index 91896502a2c..9079bf89752 100644 --- a/.github/actions/build-electron/action.yml +++ b/.github/actions/build-electron/action.yml @@ -17,6 +17,9 @@ inputs: is-release: description: 'Is release build' required: true + strip-binaries: + description: 'Strip binaries (Linux only)' + required: false generate-symbols: description: 'Generate symbols' required: true diff --git a/.github/workflows/linux-publish.yml b/.github/workflows/linux-publish.yml index 14eedbdd089..cee3180e31c 100644 --- a/.github/workflows/linux-publish.yml +++ b/.github/workflows/linux-publish.yml @@ -49,6 +49,7 @@ jobs: is-release: true gn-build-type: release generate-symbols: true + strip-binaries: true upload-to-storage: ${{ inputs.upload-to-storage }} secrets: inherit @@ -64,6 +65,7 @@ jobs: is-release: true gn-build-type: release generate-symbols: true + strip-binaries: true upload-to-storage: ${{ inputs.upload-to-storage }} secrets: inherit @@ -79,5 +81,6 @@ jobs: is-release: true gn-build-type: release generate-symbols: true + strip-binaries: true upload-to-storage: ${{ inputs.upload-to-storage }} secrets: inherit \ No newline at end of file diff --git a/.github/workflows/pipeline-segment-electron-build.yml b/.github/workflows/pipeline-segment-electron-build.yml index 839ed923f17..1b3279ab765 100644 --- a/.github/workflows/pipeline-segment-electron-build.yml +++ b/.github/workflows/pipeline-segment-electron-build.yml @@ -44,6 +44,11 @@ on: required: true type: string default: '0' + strip-binaries: + description: 'Strip the binaries before release (Linux only)' + required: false + type: boolean + default: false is-asan: description: 'Building the Address Sanitizer (ASan) Linux build' required: false @@ -186,6 +191,7 @@ jobs: artifact-platform: ${{ inputs.target-platform == 'linux' && 'linux' || 'darwin' }} is-release: '${{ inputs.is-release }}' generate-symbols: '${{ inputs.generate-symbols }}' + strip-binaries: '${{ inputs.strip-binaries }}' upload-to-storage: '${{ inputs.upload-to-storage }}' is-asan: '${{ inputs.is-asan }}' - name: Set GN_EXTRA_ARGS for MAS Build