mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

notify devtools opened and closed once per lifetime

Browse source
This commit is contained in:
deepak1556 2016-05-12 19:16:13 +05:30
parent 7e0918f95a
commit a01f8ba739
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
brightray/browser/inspectable_web_contents_impl.cc
View file

@ -368,6 +368,9 @@ void InspectableWebContentsImpl::LoadCompleted() {
// If the devtools can dock, "SetIsDocked" will be called by devtools itself. // If the devtools can dock, "SetIsDocked" will be called by devtools itself.
if (!can_dock_) if (!can_dock_)
SetIsDocked(DispatchCallback(), false); SetIsDocked(DispatchCallback(), false);
if (view_->GetDelegate())
view_->GetDelegate()->DevToolsOpened();
} }
void InspectableWebContentsImpl::SetInspectedPageBounds(const gfx::Rect& rect) { void InspectableWebContentsImpl::SetInspectedPageBounds(const gfx::Rect& rect) {
@ -618,6 +621,9 @@ void InspectableWebContentsImpl::WebContentsDestroyed() {
for (const auto& pair : pending_requests_) for (const auto& pair : pending_requests_)
delete pair.first; delete pair.first;
if (view_ && view_->GetDelegate())
view_->GetDelegate()->DevToolsClosed();
} }
bool InspectableWebContentsImpl::AddMessageToConsole( bool InspectableWebContentsImpl::AddMessageToConsole(

4
brightray/browser/inspectable_web_contents_view_mac.mm
View file

@ -29,14 +29,10 @@ gfx::NativeView InspectableWebContentsViewMac::GetNativeView() const {
void InspectableWebContentsViewMac::ShowDevTools() { void InspectableWebContentsViewMac::ShowDevTools() {
[view_ setDevToolsVisible:YES]; [view_ setDevToolsVisible:YES];
if (GetDelegate())
GetDelegate()->DevToolsOpened();
} }
void InspectableWebContentsViewMac::CloseDevTools() { void InspectableWebContentsViewMac::CloseDevTools() {
[view_ setDevToolsVisible:NO]; [view_ setDevToolsVisible:NO];
if (GetDelegate())
GetDelegate()->DevToolsClosed();
} }
bool InspectableWebContentsViewMac::IsDevToolsViewShowing() { bool InspectableWebContentsViewMac::IsDevToolsViewShowing() {

4
brightray/browser/views/inspectable_web_contents_view_views.cc
View file

@ -118,8 +118,6 @@ void InspectableWebContentsViewViews::ShowDevTools() {
devtools_web_view_->RequestFocus(); devtools_web_view_->RequestFocus();
Layout(); Layout();
} }
if (GetDelegate())
GetDelegate()->DevToolsOpened();
} }
void InspectableWebContentsViewViews::CloseDevTools() { void InspectableWebContentsViewViews::CloseDevTools() {
@ -137,8 +135,6 @@ void InspectableWebContentsViewViews::CloseDevTools() {
devtools_web_view_->SetWebContents(NULL); devtools_web_view_->SetWebContents(NULL);
Layout(); Layout();
} }
if (GetDelegate())
GetDelegate()->DevToolsClosed();
} }
bool InspectableWebContentsViewViews::IsDevToolsViewShowing() { bool InspectableWebContentsViewViews::IsDevToolsViewShowing() {