fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents (#38842)

fix: crash calling removeBrowserView() with destroyed webContents https://github.com/electron/electron/issues/37642
2023-06-21 21:20:54 +02:00 · 2023-06-21 21:20:54 +02:00 · a00a25376d
commit a00a25376d
parent ce6fe040fe
3 changed files with 21 additions and 0 deletions
--- a/shell/browser/api/electron_api_browser_view.cc
+++ b/shell/browser/api/electron_api_browser_view.cc
@ -131,6 +131,10 @@ void BrowserView::WebContentsDestroyed() {
  Unpin();
 }

+void BrowserView::OnCloseContents() {
+  api_web_contents_ = nullptr;
+}
+
 // static
 gin::Handle<BrowserView> BrowserView::New(gin_helper::ErrorThrower thrower,
                                          gin::Arguments* args) {