From 9ffffdb6ef202bd93be496b53fdd4156dd3504ce Mon Sep 17 00:00:00 2001 From: Sergey <45919738+serd2011@users.noreply.github.com> Date: Wed, 31 May 2023 22:56:06 +0300 Subject: [PATCH] docs: fix performance tutorial (#38469) * docs: fixed "Analyze runtime performance" link * docs: added missing list item --- docs/tutorial/performance.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/tutorial/performance.md b/docs/tutorial/performance.md index d75cc6fb8abc..6e0910461cfe 100644 --- a/docs/tutorial/performance.md +++ b/docs/tutorial/performance.md @@ -54,7 +54,7 @@ at once, consider the [Chrome Tracing](https://www.chromium.org/developers/how-t ### Recommended Reading -* [Get Started With Analyzing Runtime Performance][chrome-devtools-tutorial] +* [Analyze runtime performance][chrome-devtools-tutorial] * [Talk: "Visual Studio Code - The First Second"][vscode-first-second] ## Checklist: Performance recommendations @@ -69,6 +69,7 @@ resource-hungry if you attempt these steps. 5. [Unnecessary polyfills](#5-unnecessary-polyfills) 6. [Unnecessary or blocking network requests](#6-unnecessary-or-blocking-network-requests) 7. [Bundle your code](#7-bundle-your-code) +8. [Call `Menu.setApplicationMenu(null)` when you do not need a default menu](#8-call-menusetapplicationmenunull-when-you-do-not-need-a-default-menu) ### 1. Carelessly including modules @@ -432,7 +433,7 @@ If you build your own menu or use a frameless window without native menu, you sh Call `Menu.setApplicationMenu(null)` before `app.on("ready")`. This will prevent Electron from setting a default menu. See also https://github.com/electron/electron/issues/35512 for a related discussion. [security]: ./security.md -[chrome-devtools-tutorial]: https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/ +[chrome-devtools-tutorial]: https://developer.chrome.com/docs/devtools/performance/ [worker-threads]: https://nodejs.org/api/worker_threads.html [web-workers]: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers [request-idle-callback]: https://developer.mozilla.org/en-US/docs/Web/API/Window/requestIdleCallback