mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix remote setInterval flake (#12263)

Browse source
This commit is contained in:
Samuel Attard 2018-03-14 14:51:47 +09:00 committed by GitHub
parent e7181eb89c
commit 9ed9885c8d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/node-spec.js
View file

@ -184,11 +184,15 @@ describe('node feature', () => {
describe('setInterval called under Chromium event loop in browser process', () => { describe('setInterval called under Chromium event loop in browser process', () => {
it('can be scheduled in time', (done) => { it('can be scheduled in time', (done) => {
let interval = null let interval = null
let clearing = false
const clear = () => { const clear = () => {
if (interval === null) { if (interval === null || clearing) {
return return
} }
// interval might trigger while clearing (remote is slow sometimes)
clearing = true
remote.getGlobal('clearInterval')(interval) remote.getGlobal('clearInterval')(interval)
clearing = false
interval = null interval = null
done() done()
} }