mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: reset node env earlier during shutdown (#23039)

Browse source
This commit is contained in:
Jeremy Apthorp 2020-04-09 16:40:58 -07:00 committed by GitHub
parent abbe7417f2
commit 9e8ee3c899
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
shell/browser/electron_browser_main_parts.cc
View file

@ -495,6 +495,7 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
// Destroy node platform after all destructors_ are executed, as they may // Destroy node platform after all destructors_ are executed, as they may
// invoke Node/V8 APIs inside them. // invoke Node/V8 APIs inside them.
node_debugger_->Stop(); node_debugger_->Stop();
node_env_.reset();
js_env_->OnMessageLoopDestroying(); js_env_->OnMessageLoopDestroying();
fake_browser_process_->PostMainMessageLoopRun(); fake_browser_process_->PostMainMessageLoopRun();