mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: remove redundant CreateExtensionsClient() (#45159)

Browse source 
refactor: remove redundant CreateExtensionsClient() (#45135)
This commit is contained in:
Charles Kerr 2025-01-14 07:57:14 -06:00 committed by GitHub
parent 3f60b86559
commit 9dccc9f4b4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
shell/renderer/renderer_client_base.cc
View file

@ -240,7 +240,7 @@ void RendererClientBase::RenderThreadStarted() {
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
auto* thread = content::RenderThread::Get();
extensions_client_.reset(CreateExtensionsClient());
extensions_client_ = std::make_unique<ElectronExtensionsClient>();
extensions::ExtensionsClient::Set(extensions_client_.get());
extensions_renderer_client_ =
@ -573,12 +573,6 @@ v8::Local<v8::Context> RendererClientBase::GetContext(
return frame->MainWorldScriptContext();
}
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
extensions::ExtensionsClient* RendererClientBase::CreateExtensionsClient() {
return new ElectronExtensionsClient;
}
#endif
bool RendererClientBase::IsWebViewFrame(
v8::Local<v8::Context> context,
content::RenderFrame* render_frame) const {

7
shell/renderer/renderer_client_base.h
View file

@ -141,13 +141,6 @@ class RendererClientBase : public content::ContentRendererClient
bool was_created_by_renderer,
const url::Origin* outermost_origin) override;
protected:
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
// app_shell embedders may need custom extensions client interfaces.
// This class takes ownership of the returned object.
virtual extensions::ExtensionsClient* CreateExtensionsClient();
#endif
private:
#if BUILDFLAG(ENABLE_ELECTRON_EXTENSIONS)
std::unique_ptr<extensions::ExtensionsClient> extensions_client_;