mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Made NotificationDelegateImpl final

Browse source 
The class is designed to call `delete` on itself and because it doesn't have
a virtual destructor, it shouldn't be derived from.
This commit is contained in:
Ales Pergl 2017-11-02 21:39:34 +01:00 committed by Cheng Zhao
parent 505f2ab9e7
commit 9ca658238b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
brightray/browser/platform_notification_service.cc
View file

@ -45,7 +45,7 @@ void OnWebNotificationAllowed(base::WeakPtr<Notification> notification,
} }
} }
class NotificationDelegateImpl : public brightray::NotificationDelegate { class NotificationDelegateImpl final : public brightray::NotificationDelegate {
public: public:
explicit NotificationDelegateImpl(const std::string& notification_id) explicit NotificationDelegateImpl(const std::string& notification_id)
: notification_id_(notification_id) {} : notification_id_(notification_id) {}