mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: make accessibilitySupportEnabled a property on app (#17362)

Browse source 
* refactor: make accessibilitySupport a prop on app

* fix docs

* update spec
This commit is contained in:
Shelley Vohr 2019-04-04 19:49:04 -07:00 • committed by GitHub
parent 11699d8611
commit 9c3cb55ef2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 56 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

27
lib/common/api/deprecate.ts
View file

@ -55,25 +55,18 @@ const deprecate: ElectronInternal.DeprecationUtil = {
})
},
// deprecate a getter/setter function in favor of a property
fnToProperty: <A extends Function, B extends Function>(propName: string, getterFn: A, setterFn: B) => {
const getterName = getterFn.name || 'function'
const setterName = setterFn.name || 'function'
const warnGetter = warnOnce(`${getterName} function`, `${propName} property `)
const warnSetter = warnOnce(`${setterName} function`, `${propName} property `)
const deprecatedGetter: unknown = function (this: any) {
warnGetter()
getterFn.apply(this, arguments)
// deprecate a getter/setter function pair in favor of a property
fnToProperty: (module: any, prop: string, getter: string, setter: string) => {
const withWarnOnce = (obj: any, key: any, oldName: string, newName: string) => {
const warn = warnOnce(oldName, newName)
return (...args: any) => {
warn()
return obj[key](...args)
}
}
const deprecatedSetter: unknown = function (this: any) {
warnSetter()
setterFn.apply(this, arguments)
}
return [deprecatedGetter as A, deprecatedSetter as B]
module[getter.substr(1)] = withWarnOnce(module, getter, `${getter.substr(1)} function`, `${prop} property`)
module[setter.substr(1)] = withWarnOnce(module, setter, `${setter.substr(1)} function`, `${prop} property`)
},
// remove a property with no replacement