mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Avoid extra copy of data in capturePage

Browse source
This commit is contained in:
Cheng Zhao 2015-03-20 10:26:22 +08:00
parent 24d615d428
commit 9bae54f917
3 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/native_window.cc
View file

@ -322,7 +322,7 @@ void NativeWindow::CapturePage(const gfx::Rect& rect,
RenderWidgetHostView* const view = contents->GetRenderWidgetHostView();
RenderWidgetHost* const host = view ? view->GetRenderWidgetHost() : nullptr;
if (!view || !host) {
callback.Run(std::vector<unsigned char>());
callback.Run(SkBitmap());
return;
}
@ -781,11 +781,7 @@ void NativeWindow::NotifyWindowUnresponsive() {
void NativeWindow::OnCapturePageDone(const CapturePageCallback& callback,
const SkBitmap& bitmap,
content::ReadbackResponse response) {
SkAutoLockPixels screen_capture_lock(bitmap);
std::vector<unsigned char> data;
if (response == content::READBACK_SUCCESS)
gfx::PNGCodec::EncodeBGRASkBitmap(bitmap, true, &data);
callback.Run(data);
callback.Run(bitmap);
}
void NativeWindow::CallDevToolsFunction(const std::string& function_name,