mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole (#30312)

Browse source
This commit is contained in:
Jeremy Rose 2021-07-30 10:18:49 -07:00 • committed by GitHub
commit 9a63d96e83
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

14
shell/browser/ui/inspectable_web_contents.cc
View file

@ -971,20 +971,6 @@ void InspectableWebContents::WebContentsDestroyed() {
view_->GetDelegate()->DevToolsClosed(); view_->GetDelegate()->DevToolsClosed();
} }
bool InspectableWebContents::DidAddMessageToConsole(
content::WebContents* source,
blink::mojom::ConsoleMessageLevel level,
const std::u16string& message,
int32_t line_no,
const std::u16string& source_id) {
logging::LogMessage("CONSOLE", line_no,
blink::ConsoleMessageLevelToLogSeverity(level))
.stream()
<< "\"" << message << "\", source: " << source_id << " (" << line_no
<< ")";
return true;
}
bool InspectableWebContents::HandleKeyboardEvent( bool InspectableWebContents::HandleKeyboardEvent(
content::WebContents* source, content::WebContents* source,
const content::NativeWebKeyboardEvent& event) { const content::NativeWebKeyboardEvent& event) {

5
shell/browser/ui/inspectable_web_contents.h
View file

@ -175,11 +175,6 @@ class InspectableWebContents
content::NavigationHandle* navigation_handle) override; content::NavigationHandle* navigation_handle) override;
// content::WebContentsDelegate: // content::WebContentsDelegate:
bool DidAddMessageToConsole(content::WebContents* source,
blink::mojom::ConsoleMessageLevel level,
const std::u16string& message,
int32_t line_no,
const std::u16string& source_id) override;
bool HandleKeyboardEvent(content::WebContents*, bool HandleKeyboardEvent(content::WebContents*,
const content::NativeWebKeyboardEvent&) override; const content::NativeWebKeyboardEvent&) override;
void CloseContents(content::WebContents* source) override; void CloseContents(content::WebContents* source) override;