mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: simplify Invoker::IsOK() (#45803)

Browse source 
* refactor: simplify Invoker::IsOK()

* refactor: might as well make it [[nodiscard]] as well
This commit is contained in:
Charles Kerr 2025-02-26 18:50:57 -06:00 • committed by GitHub
commit 989918a59c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
shell/common/gin_helper/function_template.h
View file

@ -262,7 +262,9 @@ class Invoker<std::index_sequence<indices...>, ArgTypes...>
: ArgumentHolder<indices, ArgTypes>(args, invoker_options)...,
args_(args) {}
bool IsOK() { return And(ArgumentHolder<indices, ArgTypes>::ok...); }
[[nodiscard]] bool IsOK() const {
return (... && ArgumentHolder<indices, ArgTypes>::ok);
}
template <typename ReturnType>
void DispatchToCallback(
@ -285,12 +287,6 @@ class Invoker<std::index_sequence<indices...>, ArgTypes...>
}
private:
static bool And() { return true; }
template <typename... T>
static bool And(bool arg1, T... args) {
return arg1 && And(args...);
}
raw_ptr<gin::Arguments> args_;
};