mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not publish release when body of release note is empty.

Browse source
This commit is contained in:
Cheng Zhao 2013-09-27 15:55:46 +08:00
parent 54b0d0c9c0
commit 95e79124eb
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
script/upload.py
View file

@ -72,9 +72,10 @@ def dist_newer_than_head():
return dist_time > int(head_time) return dist_time > int(head_time)
def get_text_with_editor(): def get_text_with_editor(name):
editor = os.environ.get('EDITOR','nano') editor = os.environ.get('EDITOR', 'nano')
initial_message = '\n# Please enter the body of your release note.' initial_message = '\n# Please enter the body of your release note for %s.' \
% name
t = tempfile.NamedTemporaryFile(suffix='.tmp', delete=False) t = tempfile.NamedTemporaryFile(suffix='.tmp', delete=False)
t.write(initial_message) t.write(initial_message)
@ -102,8 +103,10 @@ def create_or_get_release_draft(github, tag):
def create_release_draft(github, tag): def create_release_draft(github, tag):
name = 'atom-shell %s' % tag name = 'atom-shell %s' % tag
body = get_text_with_editor() body = get_text_with_editor(name)
print body if body == '':
sys.stderr.write('Quit due to empty release note.\n')
sys.exit(0)
data = dict(tag_name=tag, target_commitish=tag, name=name, body=body, data = dict(tag_name=tag, target_commitish=tag, name=name, body=body,
draft=True) draft=True)