mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: add missing buffer size check in nativeImage (#17465)

Browse source
This commit is contained in:
Milan Burda 2019-03-26 02:13:39 +01:00 • committed by Cheng Zhao
parent 6c20c6e668
commit 95df531b33
2 changed files with 97 additions and 56 deletions
Download patch file Download diff file Expand all files Collapse all files

17
spec/api-native-image-spec.js
View file

@ -156,6 +156,11 @@ describe('nativeImage module', () => {
expect(nativeImage.createFromBuffer(Buffer.from([])).isEmpty()).to.be.true()
})
it('returns an empty image when the buffer is too small', () => {
const image = nativeImage.createFromBuffer(Buffer.from([1, 2, 3, 4]), { width: 100, height: 100 })
expect(image.isEmpty()).to.be.true()
})
it('returns an image created from the given buffer', () => {
const imageA = nativeImage.createFromPath(path.join(__dirname, 'fixtures', 'assets', 'logo.png'))
@ -476,6 +481,18 @@ describe('nativeImage module', () => {
})
describe('addRepresentation()', () => {
it('does not add representation when the buffer is too small', () => {
const image = nativeImage.createEmpty()
image.addRepresentation({
buffer: Buffer.from([1, 2, 3, 4]),
width: 100,
height: 100
})
expect(image.isEmpty()).to.be.true()
})
it('supports adding a buffer representation for a scale factor', () => {
const image = nativeImage.createEmpty()