mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Update cpplint

Browse source
This commit is contained in:
Cheng Zhao 2015-06-05 12:07:27 +08:00
parent 56747e975e
commit 95d28c398e
14 changed files with 77 additions and 77 deletions
Download patch file Download diff file Expand all files Collapse all files

4
brightray/browser/browser_context.cc
View file

@ -33,11 +33,11 @@ class BrowserContext::ResourceContext : public content::ResourceContext {
} }
private: private:
virtual net::HostResolver* GetHostResolver() override { net::HostResolver* GetHostResolver() override {
return getter_->host_resolver(); return getter_->host_resolver();
} }
virtual net::URLRequestContext* GetRequestContext() override { net::URLRequestContext* GetRequestContext() override {
return getter_->GetURLRequestContext(); return getter_->GetURLRequestContext();
} }

4
brightray/browser/browser_context.h
View file

@ -40,9 +40,9 @@ class BrowserContext : public content::BrowserContext,
virtual void RegisterPrefs(PrefRegistrySimple* pref_registry) {} virtual void RegisterPrefs(PrefRegistrySimple* pref_registry) {}
// URLRequestContextGetter::Delegate: // URLRequestContextGetter::Delegate:
virtual net::NetworkDelegate* CreateNetworkDelegate() override; net::NetworkDelegate* CreateNetworkDelegate() override;
virtual base::FilePath GetPath() const override; base::FilePath GetPath() const override;
private: private:
class ResourceContext; class ResourceContext;

12
brightray/browser/browser_main_parts.h
View file

@ -39,12 +39,12 @@ class BrowserMainParts : public content::BrowserMainParts {
protected: protected:
// content::BrowserMainParts: // content::BrowserMainParts:
virtual void PreEarlyInitialization() override; void PreEarlyInitialization() override;
virtual void ToolkitInitialized() override; void ToolkitInitialized() override;
virtual void PreMainMessageLoopStart() override; void PreMainMessageLoopStart() override;
virtual void PreMainMessageLoopRun() override; void PreMainMessageLoopRun() override;
virtual void PostMainMessageLoopRun() override; void PostMainMessageLoopRun() override;
virtual int PreCreateThreads() override; int PreCreateThreads() override;
// Subclasses should override this to provide their own BrowserContxt // Subclasses should override this to provide their own BrowserContxt
// implementation. The caller takes ownership of the returned object. // implementation. The caller takes ownership of the returned object.

15
brightray/browser/devtools_ui.cc
View file

@ -52,15 +52,14 @@ std::string GetMimeTypeForPath(const std::string& path) {
class BundledDataSource : public content::URLDataSource { class BundledDataSource : public content::URLDataSource {
public: public:
explicit BundledDataSource() { BundledDataSource() {}
}
// content::URLDataSource implementation. // content::URLDataSource implementation.
virtual std::string GetSource() const override { std::string GetSource() const override {
return kChromeUIDevToolsBundledHost; return kChromeUIDevToolsBundledHost;
} }
virtual void StartDataRequest(const std::string& path, void StartDataRequest(const std::string& path,
int render_process_id, int render_process_id,
int render_view_id, int render_view_id,
const GotDataCallback& callback) override { const GotDataCallback& callback) override {
@ -79,19 +78,19 @@ class BundledDataSource : public content::URLDataSource {
callback.Run(bytes.get()); callback.Run(bytes.get());
} }
virtual std::string GetMimeType(const std::string& path) const override { std::string GetMimeType(const std::string& path) const override {
return GetMimeTypeForPath(path); return GetMimeTypeForPath(path);
} }
virtual bool ShouldAddContentSecurityPolicy() const override { bool ShouldAddContentSecurityPolicy() const override {
return false; return false;
} }
virtual bool ShouldDenyXFrameOptions() const override { bool ShouldDenyXFrameOptions() const override {
return false; return false;
} }
virtual bool ShouldServeMimeTypeAsContentTypeHeader() const override { bool ShouldServeMimeTypeAsContentTypeHeader() const override {
return true; return true;
} }

12
brightray/browser/inspectable_web_contents_view_mac.h
View file

@ -17,12 +17,12 @@ class InspectableWebContentsViewMac : public InspectableWebContentsView {
InspectableWebContentsImpl* inspectable_web_contents_impl); InspectableWebContentsImpl* inspectable_web_contents_impl);
virtual ~InspectableWebContentsViewMac(); virtual ~InspectableWebContentsViewMac();
virtual gfx::NativeView GetNativeView() const override; gfx::NativeView GetNativeView() const override;
virtual void ShowDevTools() override; void ShowDevTools() override;
virtual void CloseDevTools() override; void CloseDevTools() override;
virtual bool IsDevToolsViewShowing() override; bool IsDevToolsViewShowing() override;
virtual void SetIsDocked(bool docked) override; void SetIsDocked(bool docked) override;
virtual void SetContentsResizingStrategy( void SetContentsResizingStrategy(
const DevToolsContentsResizingStrategy& strategy) override; const DevToolsContentsResizingStrategy& strategy) override;
InspectableWebContentsImpl* inspectable_web_contents() { InspectableWebContentsImpl* inspectable_web_contents() {

3
brightray/browser/linux/notification_presenter_linux.cc
View file

@ -107,7 +107,8 @@ void NotificationPresenterLinux::ShowNotification(
// Zen Nature" is difficult, we will test for the presence of the indicate // Zen Nature" is difficult, we will test for the presence of the indicate
// dbus service // dbus service
if (!UnityIsRunning()) { if (!UnityIsRunning()) {
notify_notification_add_action(notification, "default", "View", OnNotificationViewThunk, this, nullptr); notify_notification_add_action(
notification, "default", "View", OnNotificationViewThunk, this, nullptr);
} }
GdkPixbuf* pixbuf = libgtk2ui::GdkPixbufFromSkBitmap(icon); GdkPixbuf* pixbuf = libgtk2ui::GdkPixbufFromSkBitmap(icon);

8
brightray/browser/media/media_capture_devices_dispatcher.h
View file

@ -51,16 +51,16 @@ class MediaCaptureDevicesDispatcher : public content::MediaObserver {
void DisableDeviceEnumerationForTesting(); void DisableDeviceEnumerationForTesting();
// Overridden from content::MediaObserver: // Overridden from content::MediaObserver:
virtual void OnAudioCaptureDevicesChanged() override; void OnAudioCaptureDevicesChanged() override;
virtual void OnVideoCaptureDevicesChanged() override; void OnVideoCaptureDevicesChanged() override;
virtual void OnMediaRequestStateChanged( void OnMediaRequestStateChanged(
int render_process_id, int render_process_id,
int render_view_id, int render_view_id,
int page_request_id, int page_request_id,
const GURL& security_origin, const GURL& security_origin,
content::MediaStreamType stream_type, content::MediaStreamType stream_type,
content::MediaRequestState state) override; content::MediaRequestState state) override;
virtual void OnCreatingAudioStream(int render_process_id, void OnCreatingAudioStream(int render_process_id,
int render_view_id) override; int render_view_id) override;
private: private:

4
brightray/browser/url_request_context_getter.h
View file

@ -52,8 +52,8 @@ class URLRequestContextGetter : public net::URLRequestContextGetter {
virtual ~URLRequestContextGetter(); virtual ~URLRequestContextGetter();
// net::URLRequestContextGetter: // net::URLRequestContextGetter:
virtual net::URLRequestContext* GetURLRequestContext() override; net::URLRequestContext* GetURLRequestContext() override;
virtual scoped_refptr<base::SingleThreadTaskRunner> GetNetworkTaskRunner() const override; scoped_refptr<base::SingleThreadTaskRunner> GetNetworkTaskRunner() const override;
net::HostResolver* host_resolver(); net::HostResolver* host_resolver();

16
brightray/browser/views/inspectable_web_contents_view_views.h
View file

@ -24,13 +24,13 @@ class InspectableWebContentsViewViews : public InspectableWebContentsView,
~InspectableWebContentsViewViews(); ~InspectableWebContentsViewViews();
// InspectableWebContentsView: // InspectableWebContentsView:
virtual views::View* GetView() override; views::View* GetView() override;
virtual views::View* GetWebView() override; views::View* GetWebView() override;
virtual void ShowDevTools() override; void ShowDevTools() override;
virtual void CloseDevTools() override; void CloseDevTools() override;
virtual bool IsDevToolsViewShowing() override; bool IsDevToolsViewShowing() override;
virtual void SetIsDocked(bool docked) override; void SetIsDocked(bool docked) override;
virtual void SetContentsResizingStrategy( void SetContentsResizingStrategy(
const DevToolsContentsResizingStrategy& strategy) override; const DevToolsContentsResizingStrategy& strategy) override;
InspectableWebContentsImpl* inspectable_web_contents() { InspectableWebContentsImpl* inspectable_web_contents() {
@ -39,7 +39,7 @@ class InspectableWebContentsViewViews : public InspectableWebContentsView,
private: private:
// views::View: // views::View:
virtual void Layout() override; void Layout() override;
// Owns us. // Owns us.
InspectableWebContentsImpl* inspectable_web_contents_; InspectableWebContentsImpl* inspectable_web_contents_;

30
brightray/browser/views/views_delegate.h
View file

@ -17,42 +17,42 @@ class ViewsDelegate : public views::ViewsDelegate {
protected: protected:
// views::ViewsDelegate: // views::ViewsDelegate:
virtual void SaveWindowPlacement(const views::Widget* window, void SaveWindowPlacement(const views::Widget* window,
const std::string& window_name, const std::string& window_name,
const gfx::Rect& bounds, const gfx::Rect& bounds,
ui::WindowShowState show_state) override; ui::WindowShowState show_state) override;
virtual bool GetSavedWindowPlacement( bool GetSavedWindowPlacement(
const views::Widget* widget, const views::Widget* widget,
const std::string& window_name, const std::string& window_name,
gfx::Rect* bounds, gfx::Rect* bounds,
ui::WindowShowState* show_state) const override; ui::WindowShowState* show_state) const override;
virtual void NotifyAccessibilityEvent( void NotifyAccessibilityEvent(
views::View* view, ui::AXEvent event_type) override; views::View* view, ui::AXEvent event_type) override;
virtual void NotifyMenuItemFocused(const base::string16& menu_name, void NotifyMenuItemFocused(const base::string16& menu_name,
const base::string16& menu_item_name, const base::string16& menu_item_name,
int item_index, int item_index,
int item_count, int item_count,
bool has_submenu) override; bool has_submenu) override;
#if defined(OS_WIN) #if defined(OS_WIN)
virtual HICON GetDefaultWindowIcon() const override; HICON GetDefaultWindowIcon() const override;
virtual HICON GetSmallWindowIcon() const override; HICON GetSmallWindowIcon() const override;
virtual bool IsWindowInMetro(gfx::NativeWindow window) const override; bool IsWindowInMetro(gfx::NativeWindow window) const override;
#elif defined(OS_LINUX) && !defined(OS_CHROMEOS) #elif defined(OS_LINUX) && !defined(OS_CHROMEOS)
virtual gfx::ImageSkia* GetDefaultWindowIcon() const override; gfx::ImageSkia* GetDefaultWindowIcon() const override;
#endif #endif
virtual views::NonClientFrameView* CreateDefaultNonClientFrameView( views::NonClientFrameView* CreateDefaultNonClientFrameView(
views::Widget* widget) override; views::Widget* widget) override;
virtual void AddRef() override; void AddRef() override;
virtual void ReleaseRef() override; void ReleaseRef() override;
virtual content::WebContents* CreateWebContents( content::WebContents* CreateWebContents(
content::BrowserContext* browser_context, content::BrowserContext* browser_context,
content::SiteInstance* site_instance) override; content::SiteInstance* site_instance) override;
virtual void OnBeforeWidgetInit( void OnBeforeWidgetInit(
views::Widget::InitParams* params, views::Widget::InitParams* params,
views::internal::NativeWidgetDelegate* delegate) override; views::internal::NativeWidgetDelegate* delegate) override;
virtual base::TimeDelta GetDefaultTextfieldObscuredRevealDuration() override; base::TimeDelta GetDefaultTextfieldObscuredRevealDuration() override;
virtual bool WindowManagerProvidesTitleBar(bool maximized) override; bool WindowManagerProvidesTitleBar(bool maximized) override;
private: private:
DISALLOW_COPY_AND_ASSIGN(ViewsDelegate); DISALLOW_COPY_AND_ASSIGN(ViewsDelegate);

8
brightray/browser/web_ui_controller_factory.h
View file

@ -18,13 +18,13 @@ class WebUIControllerFactory : public content::WebUIControllerFactory {
explicit WebUIControllerFactory(BrowserContext* browser_context); explicit WebUIControllerFactory(BrowserContext* browser_context);
virtual ~WebUIControllerFactory(); virtual ~WebUIControllerFactory();
virtual content::WebUI::TypeID GetWebUIType( content::WebUI::TypeID GetWebUIType(
content::BrowserContext* browser_context, const GURL& url) const override; content::BrowserContext* browser_context, const GURL& url) const override;
virtual bool UseWebUIForURL(content::BrowserContext* browser_context, bool UseWebUIForURL(content::BrowserContext* browser_context,
const GURL& url) const override; const GURL& url) const override;
virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context, bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,
const GURL& url) const override; const GURL& url) const override;
virtual content::WebUIController* CreateWebUIControllerForURL( content::WebUIController* CreateWebUIControllerForURL(
content::WebUI* web_ui, content::WebUI* web_ui,
const GURL& url) const override; const GURL& url) const override;

6
brightray/common/main_delegate.h
View file

@ -49,11 +49,11 @@ class MainDelegate : public content::ContentMainDelegate {
virtual void OverrideFrameworkBundlePath(); virtual void OverrideFrameworkBundlePath();
#endif #endif
virtual bool BasicStartupComplete(int* exit_code) override; bool BasicStartupComplete(int* exit_code) override;
virtual void PreSandboxStartup() override; void PreSandboxStartup() override;
private: private:
virtual content::ContentBrowserClient* CreateContentBrowserClient() override; content::ContentBrowserClient* CreateContentBrowserClient() override;
void InitializeResourceBundle(); void InitializeResourceBundle();

2
brightray/vendor/google-styleguide vendored

@ -1 +1 @@
Subproject commit 8025f5495c04f1cf9e0d65a0aaa97b58c304faf7 Subproject commit ba88c8a53f1b563c43fc063cc048e5efdc238c18