mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: [gn] remove now-meaningless skia-related #defines (#13496)

Browse source 
`SK_SUPPORT_LEGACY_GETTOPDEVICE` was removed in [Jan 2017](https://chromium.googlesource.com/skia/+/76467a11a0aa4ba15f0f2e3ee078ba9b6ecbaa91)

`SK_SUPPORT_LEGACY_SAFESIZE64` was removed in [Oct 2017](https://chromium.googlesource.com/skia/+/3bd0fece5fadd522c2e8c1b0ca9934d7455d9ccd)
This commit is contained in:
Jeremy Apthorp 2018-06-29 08:36:20 -07:00 • committed by GitHub
parent e42c6d3eb7
commit 9525c94b5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
BUILD.gn
View file

@ -271,8 +271,6 @@ static_library("electron_lib") {
] ]
} }
defines = [ defines = [
# This is defined in skia/skia_common.gypi.
"SK_SUPPORT_LEGACY_GETTOPDEVICE",
# Disable warnings for g_settings_list_schemas. # Disable warnings for g_settings_list_schemas.
"GLIB_DISABLE_DEPRECATION_WARNINGS", "GLIB_DISABLE_DEPRECATION_WARNINGS",
@ -280,9 +278,6 @@ static_library("electron_lib") {
"USING_V8_SHARED", "USING_V8_SHARED",
"USING_V8_PLATFORM_SHARED", "USING_V8_PLATFORM_SHARED",
"USING_V8_BASE_SHARED", "USING_V8_BASE_SHARED",
# Enables SkBitmap size 64 operations
#"SK_SUPPORT_LEGACY_SAFESIZE64", # doesn't seem to be needed to build?
] ]
include_dirs = [ include_dirs = [
"chromium_src", "chromium_src",

5
electron.gyp
View file

@ -272,8 +272,6 @@
'NODE_SHARED_MODE', 'NODE_SHARED_MODE',
'HAVE_OPENSSL=1', 'HAVE_OPENSSL=1',
'HAVE_INSPECTOR=1', 'HAVE_INSPECTOR=1',
# This is defined in skia/skia_common.gypi.
'SK_SUPPORT_LEGACY_GETTOPDEVICE',
# Disable warnings for g_settings_list_schemas. # Disable warnings for g_settings_list_schemas.
'GLIB_DISABLE_DEPRECATION_WARNINGS', 'GLIB_DISABLE_DEPRECATION_WARNINGS',
# Defined in Chromium but not exposed in its gyp file. # Defined in Chromium but not exposed in its gyp file.
@ -287,9 +285,6 @@
# See Chromium src/third_party/protobuf/BUILD.gn # See Chromium src/third_party/protobuf/BUILD.gn
'GOOGLE_PROTOBUF_NO_RTTI', 'GOOGLE_PROTOBUF_NO_RTTI',
'GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER', 'GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER',
# Enables SkBitmap size 64 operations
'SK_SUPPORT_LEGACY_SAFESIZE64',
], ],
'sources': [ 'sources': [
'<@(lib_sources)', '<@(lib_sources)',