From 9513486bf3443ae72a990a38514718e3333b2399 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Mon, 17 Mar 2025 08:39:55 -0500 Subject: [PATCH] refactor: use `GetDefaultStoragePartition()` instead of `GetStoragePartition(nullptr)` (#46064) refactor: use GetDefaultStoragePartition() Use GetDefaultStorageParition() instead of GetStoragePartition(nullptr) - It improves code uniformity, since we use get-default everywhere else - It's more readable - It's marginally faster, since GetStoragePartition() has more steps Added in https://github.com/electron/electron/pull/28907/commits/49b0a1bf4a6c032d1788aac56c1e5eaa0f61e3d3 --- shell/browser/api/electron_api_session.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/shell/browser/api/electron_api_session.cc b/shell/browser/api/electron_api_session.cc index 22fc75e3bf6c..ffc710b4a026 100644 --- a/shell/browser/api/electron_api_session.cc +++ b/shell/browser/api/electron_api_session.cc @@ -701,14 +701,13 @@ v8::Local Session::ClearStorageData(gin::Arguments* args) { ClearStorageDataOptions options; args->GetNext(&options); - auto* storage_partition = browser_context()->GetStoragePartition(nullptr); if (options.storage_types & StoragePartition::REMOVE_DATA_MASK_COOKIES) { // Reset media device id salt when cookies are cleared. // https://w3c.github.io/mediacapture-main/#dom-mediadeviceinfo-deviceid MediaDeviceIDSalt::Reset(browser_context()->prefs()); } - storage_partition->ClearData( + browser_context()->GetDefaultStoragePartition()->ClearData( options.storage_types, options.quota_types, options.storage_key, base::Time(), base::Time::Max(), base::BindOnce(gin_helper::Promise::ResolvePromise, @@ -717,8 +716,7 @@ v8::Local Session::ClearStorageData(gin::Arguments* args) { } void Session::FlushStorageData() { - auto* storage_partition = browser_context()->GetStoragePartition(nullptr); - storage_partition->Flush(); + browser_context()->GetDefaultStoragePartition()->Flush(); } v8::Local Session::SetProxy(gin::Arguments* args) {