From 95073decd390734dd78d993194be069a23bf5e4c Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Thu, 27 Aug 2020 16:24:52 -0700 Subject: [PATCH] chore: remove bv before setting owner window (#25172) --- shell/browser/api/electron_api_base_window.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/browser/api/electron_api_base_window.cc b/shell/browser/api/electron_api_base_window.cc index dad65dbb299..5723d583564 100644 --- a/shell/browser/api/electron_api_base_window.cc +++ b/shell/browser/api/electron_api_base_window.cc @@ -1058,8 +1058,8 @@ void BaseWindow::ResetBrowserViews() { &browser_view) && !browser_view.IsEmpty()) { if (browser_view->web_contents()) { - browser_view->web_contents()->SetOwnerWindow(nullptr); window_->RemoveBrowserView(browser_view->view()); + browser_view->web_contents()->SetOwnerWindow(nullptr); } }