mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Enable context isolation on child windows

Browse source
This commit is contained in:
Kevin Sawicki 2017-01-10 09:37:38 -08:00
parent eef72647b4
commit 95054f443f
2 changed files with 14 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/browser/guest-window-manager.js
View file

@ -47,6 +47,11 @@ const mergeBrowserWindowOptions = function (embedder, options) {
options.webPreferences.nodeIntegration = false options.webPreferences.nodeIntegration = false
} }
// Enable context isolation on child window if enable on parent window
if (embedder.getWebPreferences().contextIsolation === true) {
options.webPreferences.contextIsolation = true
}
// Sets correct openerId here to give correct options to 'new-window' event handler // Sets correct openerId here to give correct options to 'new-window' event handler
options.webPreferences.openerId = embedder.id options.webPreferences.openerId = embedder.id

9
spec/api-browser-window-spec.js
View file

@ -1903,6 +1903,15 @@ describe('BrowserWindow module', function () {
}) })
w.loadURL('file://' + fixtures + '/api/isolated.html') w.loadURL('file://' + fixtures + '/api/isolated.html')
}) })
it('enables context isolation on child windows', function (done) {
app.once('browser-window-created', function (event, window) {
assert.equal(window.webContents.getWebPreferences().contextIsolation, true)
done()
})
w.loadURL('file://' + fixtures + '/pages/window-open.html')
})
}) })
describe('offscreen rendering', function () { describe('offscreen rendering', function () {