diff --git a/atom/common/api/atom_api_crash_reporter.cc b/atom/common/api/atom_api_crash_reporter.cc index e396356cdbb8..4b51a88b9f3d 100644 --- a/atom/common/api/atom_api_crash_reporter.cc +++ b/atom/common/api/atom_api_crash_reporter.cc @@ -11,6 +11,8 @@ #include "atom/common/node_includes.h" +using crash_reporter::CrashReporter; + namespace mate { template<> @@ -32,10 +34,9 @@ struct Converter > { }; template<> -struct Converter > { +struct Converter > { static v8::Local ToV8(v8::Isolate* isolate, - const std::vector< - crash_reporter::CrashReporter::UploadReportResult>& reports) { + const std::vector& reports) { v8::Local result(v8::Array::New(isolate, reports.size())); for (size_t i = 0; i < reports.size(); ++i) { mate::Dictionary dict(isolate, v8::Object::New(isolate)); @@ -54,14 +55,12 @@ struct Converter namespace { -std::vector -GetUploadedReports() { - return (crash_reporter::CrashReporter::GetInstance())->GetUploadedReports(); +std::vector GetUploadedReports() { + return (CrashReporter::GetInstance())->GetUploadedReports(); } void Initialize(v8::Local exports, v8::Local unused, v8::Local context, void* priv) { - using crash_reporter::CrashReporter; mate::Dictionary dict(context->GetIsolate(), exports); dict.SetMethod("start", base::Bind(&CrashReporter::Start, diff --git a/atom/common/crash_reporter/crash_reporter.cc b/atom/common/crash_reporter/crash_reporter.cc index 5d1e2146cc86..25dbf6065d96 100644 --- a/atom/common/crash_reporter/crash_reporter.cc +++ b/atom/common/crash_reporter/crash_reporter.cc @@ -39,7 +39,8 @@ void CrashReporter::SetUploadParameters(const StringMap& parameters) { SetUploadParameters(); } -std::vector CrashReporter::GetUploadedReports() { +std::vector +CrashReporter::GetUploadedReports() { return std::vector(); } diff --git a/atom/common/crash_reporter/crash_reporter.h b/atom/common/crash_reporter/crash_reporter.h index c81111b596bd..6cfa5b3f3a59 100644 --- a/atom/common/crash_reporter/crash_reporter.h +++ b/atom/common/crash_reporter/crash_reporter.h @@ -7,6 +7,7 @@ #include #include +#include #include #include "base/basictypes.h" @@ -16,7 +17,7 @@ namespace crash_reporter { class CrashReporter { public: typedef std::map StringMap; - typedef std::pair UploadReportResult; // upload-date, id + typedef std::pair UploadReportResult; // upload-date, id static CrashReporter* GetInstance(); diff --git a/atom/common/crash_reporter/crash_reporter_mac.h b/atom/common/crash_reporter/crash_reporter_mac.h index 25eb0e28ba95..ca31237cc154 100644 --- a/atom/common/crash_reporter/crash_reporter_mac.h +++ b/atom/common/crash_reporter/crash_reporter_mac.h @@ -6,6 +6,7 @@ #define ATOM_COMMON_CRASH_REPORTER_CRASH_REPORTER_MAC_H_ #include +#include #include "atom/common/crash_reporter/crash_reporter.h" #include "base/compiler_specific.h"