mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Backport (3-0-x) - fix: deprecate properties in app.getAppMetrics() (#13453)

Browse source 
* fix: deprecate properties in app.getAppMetrics()

* address feedback from review

* fix deprecated property location

* simplify test
This commit is contained in:
trop[bot] 2018-06-27 19:07:39 +10:00 • committed by Samuel Attard
parent ec993214a2
commit 93edf2edd3
4 changed files with 47 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

19
docs/api/breaking-changes.md
View file

@ -35,9 +35,9 @@ app.releaseSingleInstanceLock()
```
# Planned Breaking API Changes (3.0)
# Breaking API Changes (3.0)
The following list includes the breaking API changes planned for Electron 3.0.
The following list includes the breaking API changes in Electron 3.0.
## `app`
@ -46,6 +46,12 @@ The following list includes the breaking API changes planned for Electron 3.0.
app.getAppMemoryInfo()
// Replace with
app.getAppMetrics()
// Deprecated
const metrics = app.getAppMetrics()
const {memory} = metrics[0]
memory.privateBytes // Deprecated property
memory.sharedBytes // Deprecated property
```
## `BrowserWindow`
@ -124,6 +130,15 @@ nativeImage.createFromBuffer(buffer, {
})
```
## `process`
```js
// Deprecated
const info = process.getProcessMemoryInfo()
const privateBytes = info.privateBytes // deprecated property
const sharedBytes = info.sharedBytes // deprecated property
```
## `screen`
```js