mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix invoking non-exist method when quiting.

Browse source
This commit is contained in:
Cheng Zhao 2014-01-08 10:30:30 +08:00
parent 367285f3f3
commit 93d5a2e195
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
common/node_bindings.cc
View file

@ -220,11 +220,20 @@ void NodeBindings::WakeupEmbedThread() {
void NodeBindings::EmbedThreadRunner(void *arg) { void NodeBindings::EmbedThreadRunner(void *arg) {
NodeBindings* self = static_cast<NodeBindings*>(arg); NodeBindings* self = static_cast<NodeBindings*>(arg);
while (!self->embed_closed_) { while (true) {
// Wait for the main loop to deal with events. // Wait for the main loop to deal with events.
uv_sem_wait(&self->embed_sem_); uv_sem_wait(&self->embed_sem_);
if (self->embed_closed_)
break;
// Wait for something to happen in uv loop.
// Note that the PollEvents() is implemented by derived classes, so when
// this class is being destructed the PollEvents() would not be available
// anymore. Because of it we must make sure we only invoke PollEvents()
// when this class is alive.
self->PollEvents(); self->PollEvents();
if (self->embed_closed_)
break;
// Deal with event in main thread. // Deal with event in main thread.
self->WakeupMainThread(); self->WakeupMainThread();