mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't reference RequestContextGetter in JS objects

Browse source 
V8 doesn't guarrentee the C++ class of JS objects will get destroyed, so
this will result in RequestContextGetter never getting freed
This commit is contained in:
Cheng Zhao 2015-09-09 19:27:28 +08:00
parent 9d51da505e
commit 93bbc0bca9
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_cookies.h
View file

@ -78,7 +78,7 @@ class Cookies : public mate::Wrappable {
// Must be called on IO thread.
net::CookieStore* GetCookieStore();
scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
net::URLRequestContextGetter* request_context_getter_;
DISALLOW_COPY_AND_ASSIGN(Cookies);
};