From 93939089eca0cf01aa2ae355b52bdbe88485355b Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 10 Mar 2016 13:26:14 -0800 Subject: [PATCH] Don't collect results in Menu.setApplicationMenu --- lib/browser/api/menu.js | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lib/browser/api/menu.js b/lib/browser/api/menu.js index 5af577872dbb..f22002e144d4 100644 --- a/lib/browser/api/menu.js +++ b/lib/browser/api/menu.js @@ -267,7 +267,6 @@ Menu.prototype._callMenuWillShow = function() { var applicationMenu = null; Menu.setApplicationMenu = function(menu) { - var j, len, results, w, windows; if (!(menu === null || menu.constructor === Menu)) { throw new TypeError('Invalid menu'); } @@ -279,15 +278,11 @@ Menu.setApplicationMenu = function(menu) { return; } menu._callMenuWillShow(); - return bindings.setApplicationMenu(menu); + bindings.setApplicationMenu(menu); } else { - windows = BrowserWindow.getAllWindows(); - results = []; - for (j = 0, len = windows.length; j < len; j++) { - w = windows[j]; - results.push(w.setMenu(menu)); - } - return results; + BrowserWindow.getAllWindows().forEach(function(window) { + window.setMenu(menu); + }); } };