From 6d8d2116318c8f3d57b8753e34390d19c92537e1 Mon Sep 17 00:00:00 2001 From: Nabeel Omer Date: Thu, 13 Oct 2016 19:45:39 +0530 Subject: [PATCH 1/4] Update online-offline-events.md --- docs/tutorial/online-offline-events.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/tutorial/online-offline-events.md b/docs/tutorial/online-offline-events.md index f89e7fad78e4..31454676eb1a 100644 --- a/docs/tutorial/online-offline-events.md +++ b/docs/tutorial/online-offline-events.md @@ -78,3 +78,4 @@ _online-status.html_ ``` +In Chrome and Safari, if the browser is not able to connect to a local area network (LAN) or a router, it is offline; all other conditions return true. So while you can assume that the browser is offline when it returns a false value, you cannot assume that a true value necessarily means that the browser can access the internet. You could be getting false positives, such as in cases where the computer is running a virtualization software that has virtual ethernet adapters that are always "connected." Therefore, if you really want to determine the online status of the browser, you should develop additional means for checking. From 392b59be4ec245ef71b712f6eec4080dcbe58d75 Mon Sep 17 00:00:00 2001 From: Nabeel Omer Date: Thu, 13 Oct 2016 20:12:44 +0530 Subject: [PATCH 2/4] Made relevant changes --- docs/tutorial/online-offline-events.md | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/tutorial/online-offline-events.md b/docs/tutorial/online-offline-events.md index 31454676eb1a..88dc179279a1 100644 --- a/docs/tutorial/online-offline-events.md +++ b/docs/tutorial/online-offline-events.md @@ -78,4 +78,12 @@ _online-status.html_ ``` -In Chrome and Safari, if the browser is not able to connect to a local area network (LAN) or a router, it is offline; all other conditions return true. So while you can assume that the browser is offline when it returns a false value, you cannot assume that a true value necessarily means that the browser can access the internet. You could be getting false positives, such as in cases where the computer is running a virtualization software that has virtual ethernet adapters that are always "connected." Therefore, if you really want to determine the online status of the browser, you should develop additional means for checking. +**NOTE:** If Electron is not able to connect to a local area network (LAN) or +a router, it is considered offline; all other conditions return true. +So while you can assume that the browser is offline when `navigator.onLine` +returns a false value, you cannot assume that a true value necessarily +means that the browser can access the internet. You could be getting false +positives, such as in cases where the computer is running a virtualization +software that has virtual ethernet adapters that are always "connected." +Therefore, if you really want to determine the online status of the browser, +you should develop additional means for checking. From 4f288e3ba269d7d67a75e51ecbf8bebb0ea52b08 Mon Sep 17 00:00:00 2001 From: Nabeel Omer Date: Thu, 13 Oct 2016 20:22:40 +0530 Subject: [PATCH 3/4] Update --- docs/tutorial/online-offline-events.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/tutorial/online-offline-events.md b/docs/tutorial/online-offline-events.md index 88dc179279a1..b231cede710b 100644 --- a/docs/tutorial/online-offline-events.md +++ b/docs/tutorial/online-offline-events.md @@ -80,10 +80,10 @@ _online-status.html_ ``` **NOTE:** If Electron is not able to connect to a local area network (LAN) or a router, it is considered offline; all other conditions return true. -So while you can assume that the browser is offline when `navigator.onLine` +So while you can assume that Electron is offline when `navigator.onLine` returns a false value, you cannot assume that a true value necessarily -means that the browser can access the internet. You could be getting false +means that Electron can access the internet. You could be getting false positives, such as in cases where the computer is running a virtualization software that has virtual ethernet adapters that are always "connected." -Therefore, if you really want to determine the online status of the browser, +Therefore, if you really want to determine the internet access status of Electron, you should develop additional means for checking. From 4f57b685bd27c1432928bce771b96b160a459b23 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 13 Oct 2016 14:16:37 -0700 Subject: [PATCH 4/4] Add backticks around true/false values --- docs/tutorial/online-offline-events.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/tutorial/online-offline-events.md b/docs/tutorial/online-offline-events.md index b231cede710b..bc9f7ecc9452 100644 --- a/docs/tutorial/online-offline-events.md +++ b/docs/tutorial/online-offline-events.md @@ -78,10 +78,11 @@ _online-status.html_ ``` + **NOTE:** If Electron is not able to connect to a local area network (LAN) or -a router, it is considered offline; all other conditions return true. +a router, it is considered offline; all other conditions return `true`. So while you can assume that Electron is offline when `navigator.onLine` -returns a false value, you cannot assume that a true value necessarily +returns a `false` value, you cannot assume that a `true` value necessarily means that Electron can access the internet. You could be getting false positives, such as in cases where the computer is running a virtualization software that has virtual ethernet adapters that are always "connected."