Make links to docs, point to the correct version
- Links to docs in the default app, pointed to the docs in the master branch. I changed them to point to the docs that match Electron's version. - Added Electron's version to the header of the default app, so it will be easier to figure out what version is currently running.
This commit is contained in:
parent
f374508a61
commit
9341b9d640
2 changed files with 27 additions and 5 deletions
|
@ -76,7 +76,11 @@
|
||||||
};
|
};
|
||||||
</script>
|
</script>
|
||||||
|
|
||||||
<h2 style="-webkit-app-region: drag">Welcome to Electron</h2>
|
<h2>
|
||||||
|
<script>
|
||||||
|
document.write(`Welcome to Electron (v${process.versions.electron})`)
|
||||||
|
</script>
|
||||||
|
</h2>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
To run your app with Electron, execute the following command under your
|
To run your app with Electron, execute the following command under your
|
||||||
|
@ -87,8 +91,18 @@
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
The <code>path-to-your-app</code> should be the path to your own Electron
|
The <code>path-to-your-app</code> should be the path to your own Electron
|
||||||
app, you can read the <a href='https://github.com/atom/electron/blob/master/docs/tutorial/quick-start.md'>quick start</a>
|
app, you can read the
|
||||||
guide in Electron's <a href='https://github.com/atom/electron/blob/master/docs'>docs</a>
|
<script>
|
||||||
|
document.write(
|
||||||
|
`<a href='https://github.com/atom/electron/blob/v${process.versions.electron}/docs/tutorial/quick-start.md'>quick start</a>`
|
||||||
|
);
|
||||||
|
</script>
|
||||||
|
guide in Electron's
|
||||||
|
<script>
|
||||||
|
document.write(
|
||||||
|
`<a href='https://github.com/atom/electron/tree/v${process.versions.electron}/docs#readme'>docs</a>`
|
||||||
|
);
|
||||||
|
</script>
|
||||||
on how to write one.
|
on how to write one.
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
|
|
|
@ -148,7 +148,11 @@ app.once('ready', function() {
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Documentation',
|
label: 'Documentation',
|
||||||
click: function() { shell.openExternal('https://github.com/atom/electron/tree/master/docs#readme') }
|
click: function() {
|
||||||
|
shell.openExternal(
|
||||||
|
`https://github.com/atom/electron/tree/v${process.versions.electron}/docs#readme`
|
||||||
|
)
|
||||||
|
}
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
label: 'Community Discussions',
|
label: 'Community Discussions',
|
||||||
|
@ -249,7 +253,11 @@ if (option.file && !option.webdriver) {
|
||||||
} catch(e) {
|
} catch(e) {
|
||||||
if (e.code == 'MODULE_NOT_FOUND') {
|
if (e.code == 'MODULE_NOT_FOUND') {
|
||||||
app.focus();
|
app.focus();
|
||||||
dialog.showErrorBox('Error opening app', 'The app provided is not a valid electron app, please read the docs on how to write one:\nhttps://github.com/atom/electron/tree/master/docs\n\n' + e.toString());
|
dialog.showErrorBox(
|
||||||
|
'Error opening app',
|
||||||
|
'The app provided is not a valid Electron app, please read the docs on how to write one:\n' +
|
||||||
|
`https://github.com/atom/electron/tree/v${process.versions.electron}/docs\n\n${e.toString()}`
|
||||||
|
);
|
||||||
process.exit(1);
|
process.exit(1);
|
||||||
} else {
|
} else {
|
||||||
console.error('App threw an error when running', e);
|
console.error('App threw an error when running', e);
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue